Open
Conversation
Review of the stdlib (and native) `PairingPoints` class. No bug fixes. Changes include: - "Default" pairing points are point at infinity (mimicking native) instead of arbitrary valid points - Add `reconstruct_from_public` for use in codec - More complete testing suite for basic functionality and tagging mechanism - Sanity tests for native `PairingPoints` class VK change is due to change in default pairing point representation from arbitrary valid to inf
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
simplifying external api and making pp aware of its defaultness, so that set_public() chooses the right path
### 🧾 Audit Context Address DSL audit comments. ### 🛠️ Changes Made - Fix typos in docs - Fix broken links (they now point at a fixed commit) - Simplify deserialisation function - Fix wrong parameter in QuadConstraintTests - Change usage of `std::visit` from `if`/`else` with `constexpr` to `overloads`. This ensures compiler failure if we forget to handle some cases (as it was: we were not handling `Call`) ### ✅ Checklist - [ ] Audited all methods of the relevant module/class - [ ] Audited the interface of the module/class with other (relevant) components - [ ] Documented existing functionality and any changes made (as per Doxygen requirements) - [ ] Resolved and/or closed all issues/TODOs pertaining to the audited files - [ ] Confirmed and documented any security or other issues found (if applicable) - [ ] Verified that tests cover all critical paths (and added tests if necessary) - [ ] Updated audit tracking for the files audited (check the start of each file you audited) ### 📌 Notes for Reviewers (Optional) Call out anything that reviewers should pay close attention to — like logic changes, performance implications, or potential regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore!: pairing points audit (#20456)
fix: default pp handling (#20516)
chore: Address DSL audit comments (#20074)
END_COMMIT_OVERRIDE