Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
LHerskind
force-pushed
the
lh/uniswap-oracle-price-feed
branch
from
c3bed62 to
c7c25f5
Compare
LHerskind
changed the title
LHerskind
force-pushed
the
lh/uniswap-oracle-price-feed
branch
3 times, most recently
from
9afe6c0 to
4e7e685
Compare
LHerskind
force-pushed
the
lh/uniswap-oracle-price-feed
branch
from
4e7e685 to
a414ecb
Compare
spypsy
reviewed
Feb 12, 2026
| } | ||
|
|
||
| /** Mainnet Uniswap V4 StateView contract address */ | ||
| export const STATE_VIEW_ADDRESS = EthAddress.fromString('0x7ffe42c4a5deea5b0fec41c94c136cf115597227'); |
Member
There was a problem hiding this comment.
do we care about supporting this in Sepolia? I see from their codebase they have an address for it
Contributor
Author
There was a problem hiding this comment.
Don't make much sense to. The contract exists, but our pool does not 🤷
Contributor
Author
There was a problem hiding this comment.
Actually, this can be a bit of a pain, because it would try to read values but get nothing back 😅 Also seeing some failures caused by this, but really not sure how it i) passed CI and ii) are not consistent.
spypsy
reviewed
Feb 12, 2026
| throw new Error('Cannot convert zero sqrtPriceX96'); | ||
| } | ||
| const Q192 = 2n ** 192n; | ||
| return (10n ** 12n * Q192) / (sqrtPriceX96 * sqrtPriceX96); |
Member
There was a problem hiding this comment.
tiny nit, should we have these constants set at the top of the file instead of computing them in every call?
LHerskind
force-pushed
the
lh/uniswap-oracle-price-feed
branch
from
a414ecb to
2321f51
Compare
spypsy
approved these changes
Feb 12, 2026
LHerskind
force-pushed
the
lh/uniswap-oracle-price-feed
branch
from
2321f51 to
1cb8102
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pr uses the seeded uniswap pool as a pricing feed for Aztec token.
When the sequencer is to propose a checkpoint, he will use the uniswap oracle and fetch the price for the last 5 blocks. He takes the average of these 5 blocks and sees that as the price of the asset, he then computes the fee asset modifier (up to 100 bps up or down) based on that value and the current value. It is included as part of the checkpoint.
Other validators will sign the payload if the fee asset modifier is valid (
-100 <= x <= 100) but does not take actual price into account for now.Notable changes: