Skip to content

chore!: remove dead columns and code from avm cpp #19442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dbanks12 merged 1 commit into from
Jan 9, 2026
Merged

chore!: remove dead columns and code from avm cpp #19442

dbanks12 merged 1 commit into from
Jan 9, 2026

Conversation

@dbanks12
Copy link
Contributor

@dbanks12 dbanks12 commented Jan 8, 2026 •
edited
Loading

Really just cleanup and a comment

@dbanks12 Graphite App
Copy link
Contributor Author

dbanks12 commented Jan 8, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

dbanks12
dbanks12 commented Jan 8, 2026
View reviewed changes
barretenberg/cpp/pil/vm2/opcodes/send_l2_to_l1_msg.pil
Comment on lines +69 to 71
// Increase num message if error is off. We increase even in the discard case, since discard only implies not writing to public inputs.
#[EMIT_L2_TO_L1_MSG_NUM_L2_TO_L1_MSGS_EMITTED_INCREASE]
sel_execute_send_l2_to_l1_msg * (prev_num_l2_to_l1_messages + (1 - sel_opcode_error) - num_l2_to_l1_messages) = 0;
Copy link
Contributor Author

@dbanks12 dbanks12 Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment was present for emit_unencrypted.pil, but omitted here. It feels helpful here too.

@dbanks12 dbanks12 requested a review from sirasistant January 8, 2026 20:07
@dbanks12 dbanks12 marked this pull request as ready for review January 8, 2026 20:07
@dbanks12 dbanks12 force-pushed the db/misc-pil-cleanup branch from 06a4ee6 to ca26413 Compare January 8, 2026 20:29
@AztecBot
Copy link
Collaborator

AztecBot commented Jan 8, 2026

Flakey Tests

🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (\0338;;http://ci.aztec-labs.com/72774f754314b278�72774f754314b2788;;�\033):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_p2p/multiple_validators_sentinel.parallel.test.ts "collects attestations for validators in proposer node when block is not published" (113s) (code: 1) group:e2e-p2p-epoch-flakes (\033dbanks12\033: chore!: remove dead columns and code from avm cpp)
\033FLAKED\033 (\0338;;http://ci.aztec-labs.com/56b2bd2c513cb835�56b2bd2c513cb8358;;�\033):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_p2p/add_rollup.test.ts (601s) (code: 124) group:e2e-p2p-epoch-flakes (\033dbanks12\033: chore!: remove dead columns and code from avm cpp)

sirasistant
sirasistant approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@sirasistant sirasistant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dbanks12 dbanks12 merged commit 2308b5b into merge-train/avm Jan 9, 2026
9 checks passed
@dbanks12 dbanks12 deleted the db/misc-pil-cleanup branch January 9, 2026 13:57
@AztecBot AztecBot mentioned this pull request Jan 9, 2026
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 9, 2026
@AztecBot
feat: merge-train/avm (#19454)
073eb9a 
BEGIN_COMMIT_OVERRIDE
feat(avm): Migrate contract db proxy to fuzzer context (#19421)
fix(avm): capping rd size and fixing pipes (#19420)
feat(avm): mutations for accumulated data (#19347)
chore!: remove dead columns and code from avm cpp (#19442)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sirasistant sirasistant sirasistant approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dbanks12 @AztecBot @sirasistant