feat: merge-train/barretenberg #19229
Open
+333
−392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#19191) ### Context with the changes done to the merge, there's no need to keep the linear combination of the claims object and all its dependencies in shplonk. This PR removes all the related methods and updates tests accordingly.
AztecBot
requested review from
IlyasRidhuan,
fcarreiro and
jeanmon
as code owners
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
### 🧾 Audit Context Audit of the Mega circuit builder. ### 🛠️ Changes Made - Tests and documentation. ### ✅ Checklist - [x] Audited all methods of the relevant module/class - [ ] Audited the interface of the module/class with other (relevant) components - [x] Documented existing functionality and any changes made (as per Doxygen requirements) - [ ] Resolved and/or closed all issues/TODOs pertaining to the audited files - [ ] Confirmed and documented any security or other issues found (if applicable) - [ ] Verified that tests cover all critical paths (and added tests if necessary) - [ ] Updated audit tracking for the files audited (check the start of each file you audited) ### 📌 Notes for Reviewers --------- Co-authored-by: notnotraju <raju@aztec-labs.com>
small edits to the circuit builder documentation. --------- Co-authored-by: notnotraju <raju@aztec-labs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore: (PCS audit) remove the linear combination of claims in shplonk (#19191)
chore: Audit of the Mega circuit builder 1 (#19192)
chore: edit to the circuit builder docs (#19214)
END_COMMIT_OVERRIDE