Skip to content

refactor: move overflow check #19175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
iAmMichaelConnor wants to merge 1 commit into
base: next
Choose a base branch
from
Open

refactor: move overflow check #19175

iAmMichaelConnor wants to merge 1 commit into from

Conversation

@iAmMichaelConnor
Copy link
Contributor

@iAmMichaelConnor iAmMichaelConnor commented Dec 20, 2025

Moves the blob overflow check to the final "checkpoint end data" absorption.
Gets rid of a function. If we ever change the size of a checkpoint end marker, this should make it easier to notice the problem.

@iAmMichaelConnor iAmMichaelConnor force-pushed the mc/check-blob-overflow-inside-absorb-end-marker branch from 6f63aa0 to 34a5e68 Compare December 22, 2025 10:01
@iAmMichaelConnor iAmMichaelConnor requested review from a team and charlielye as code owners December 22, 2025 10:01
@iAmMichaelConnor
Copy link
Contributor Author

iAmMichaelConnor commented Dec 22, 2025 •
edited
Loading

Well this rebase went wrong.

Edit: rectified. Nervous laughter.

@iAmMichaelConnor iAmMichaelConnor force-pushed the mc/check-blob-overflow-inside-absorb-end-marker branch from 34a5e68 to 0a5af3a Compare December 22, 2025 10:07
@iAmMichaelConnor iAmMichaelConnor force-pushed the mc/check-blob-overflow-inside-absorb-end-marker branch from 0a5af3a to 96711a9 Compare December 22, 2025 10:09
@iAmMichaelConnor iAmMichaelConnor removed request for a team and charlielye December 22, 2025 10:10
@AztecBot
Copy link
Collaborator

AztecBot commented Dec 22, 2025

Flakey Tests

🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (\0338;;http://ci.aztec-labs.com/29a327b8652b6189�29a327b8652b61898;;�\033): LOG_LEVEL=debug yarn-project/scripts/run_test.sh p2p/src/client/p2p_client.test.ts (74s) (code: 1) group:e2e-p2p-epoch-flakes (\033iAmMichaelConnor\033: refactor: move overflow check)
\033FLAKED\033 (\0338;;http://ci.aztec-labs.com/5cd4896d9b18fc7e�5cd4896d9b18fc7e8;;�\033): yarn-project/scripts/run_test.sh p2p/src/mem_pools/tx_pool/aztec_kv_tx_pool.test.ts (463s) (code: 134) group:e2e-p2p-epoch-flakes (\033iAmMichaelConnor\033: refactor: move overflow check)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LeilaWang LeilaWang Awaiting requested review from LeilaWang LeilaWang is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iAmMichaelConnor @AztecBot