-
Notifications
You must be signed in to change notification settings - Fork 575
fix(docs): Updating info in aztec-nr docs #19166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
…, structure, upgrades, dependencies, and global variables - Updated "how to profile transactions" guide to clarify profiling steps and output analysis. - Revised "contract artifact" documentation to improve clarity on artifact structure and usage. - Enhanced "contract structure" section with clearer explanations and next steps for developers. - Streamlined "contract upgrades" documentation to emphasize upgrade processes and security considerations. - Expanded "aztec.nr dependencies" section to include detailed library paths and descriptions. - Improved "global variables" documentation to clarify differences between private and public contexts.
…tec-packages into jc/docs/aztec-nr-review
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
sklppy88
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beautiful !
|
|
||
| :::tip get_notes vs pop_notes | ||
|
|
||
| - `get_notes`: Retrieves notes without nullifying. Use when you need to read note data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note data is not guaranteed to be current, or non-nullified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an aside, I think we should move everything to include codes. Right now it's a mix of code blocks and include codes.
| The message structures are: | ||
| - `L1Actor` and `L2Actor` - Represent entities on L1 and L2 respectively | ||
| - `L1ToL2Msg` - Message sent from L1 to L2 | ||
| - `L2ToL1Msg` - Message sent from L2 to L1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section a bit verbose
Summary
Comprehensive documentation review and improvements for the aztec-nr developer documentation. This PR focuses on improving clarity, structure, accuracy, and consistency across the Aztec smart contract development guides.
Changes Include:
Framework & Core Concepts
Function Documentation
How-To Guides
Advanced Topics
L1-L2 Messaging
Setup & Installation
General Improvements