feat: add GitHub Action for rollup upgrade payload generation #19104
Conversation
ludamad
requested review from
LHerskind,
Maddiaa0,
charlielye and
just-mitch
as code owners
ludamad
force-pushed
the
ad/feat/rollup-upgrade-payload-action
branch
from
8167d6e to
0a713be
Compare
AztecBot
force-pushed
the
ad/feat/rollup-upgrade-payload-action
branch
from
0a713be to
9a8632a
Compare
AztecBot
force-pushed
the
ad/feat/rollup-upgrade-payload-action
branch
from
9a8632a to
ab84102
Compare
Adds a new governance payload contract that registers a new rollup version in both the Registry and GSE contracts. This enables governance-controlled rollup upgrades. Includes: - RegisterNewRollupVersionPayload.sol contract - CreateRollupUpgradePayload.s.sol forge script - GitHub Action workflow for payload creation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ludamad
force-pushed
the
ad/feat/rollup-upgrade-payload-action
branch
from
1c15c2b to
dd8c6c9
Compare
| REGISTRY_ADDRESS: ${{ inputs.registry_address }} | ||
| ROLLUP_ADDRESS: ${{ inputs.rollup_address }} | ||
| run: | | ||
| forge script script/deploy/CreateRollupUpgradePayload.s.sol:CreateRollupUpgradePayload \ |
There was a problem hiding this comment.
this needs to --verify --verifier etherscan --etherscan-api-key XXX.
There was a problem hiding this comment.
ah right I missed this as it was a simple payload
| /// - ROLLUP_ADDRESS: Address of the new Rollup to register | ||
| /// | ||
| /// Outputs the deployed payload address. | ||
| contract CreateRollupUpgradePayload is Script { |
There was a problem hiding this comment.
I'm wondering if we should just deploy the new rollup in here. Thoughts @LHerskind ?
There was a problem hiding this comment.
The best flow I see is running one github action, and having the rollup and upgrade payload we want deployed.
There was a problem hiding this comment.
Ah I was wonder, wasn't sure if people would want to first smoke test a deployed rollup then do this
There was a problem hiding this comment.
Makes sense, though there is nothing stopping us from doing both and still smoke testing.
There was a problem hiding this comment.
I would include the rollup deployment. It will also force us now to define the configuration parameters we want to use.
Adds a new GitHub Action workflow that generates rollup upgrade payloads, along with a forge script for convenience in doing so