feat: remove bincode support, use msgpack-compact only #19047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludamad
requested review from
charlielye,
dbanks12,
fcarreiro and
sirasistant
as code owners
ludamad
force-pushed
the
ad/msgpack-compact-only
branch
from
66b8f01 to
ece175f
Compare
aakoshh
reviewed
Dec 17, 2025
aakoshh
reviewed
Dec 17, 2025
This was referenced Dec 17, 2025
This was referenced Jan 6, 2026
This moves us over to the msgpack-compact serialization format for ACIR. As well, the coming changes will no longer have msgpack_pack generated for these objects, as it was code only used in tests. I have removed such tests. The bbapi tests that use this are nice but would need to be moved to tests that consume acir artifacts. but most were quite simple. # Summary - Replaced `deserialize_any_format` with `deserialize_msgpack_compact`, moving everything to new msgpack format - Updated test files to use msgpack serialization - Removed bincode declarations and implementations from serde files Fixes A-450 Co-authored-by: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
AztecBot
force-pushed
the
ad/msgpack-compact-only
branch
from
2c1ae99 to
bddae56
Compare
ledwards2225
approved these changes
Jan 12, 2026
| BB_ASSERT(!buf.empty(), "deserialize_msgpack_compact: buffer is empty"); | ||
|
|
||
| // Expect format marker for msgpack or msgpack-compact | ||
| const uint8_t FORMAT_MSGPACK = 2; |
Contributor
There was a problem hiding this comment.
Did this start at 2 because it was implicitly the 2nd option after bincode?
Contributor
There was a problem hiding this comment.
Maybe we don't want to change anyway to reduce breaking-ness?
Collaborator
Flakey Tests🤖 says: This CI run detected 3 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves us over to the msgpack-compact serialization format for ACIR. As well, the coming changes will no longer have msgpack_pack generated for these objects, as it was code only used in tests. I have removed such tests. The bbapi tests that use this are nice but would need to be moved to tests that consume acir artifacts. but most were quite simple.
Summary
deserialize_any_formatwithdeserialize_msgpack_compact, moving everything to new msgpack formatFixes A-450