proof of note creation #9
Conversation
| type = "contract" | ||
|
|
||
| [dependencies] | ||
| aztec = { git = "https://github.com/AztecProtocol/aztec-packages/", tag = "v0.87.9", directory = "noir-projects/aztec-nr/aztec" } |
There was a problem hiding this comment.
Can you update this to work with the latest testnet version, 2.0.3?
There was a problem hiding this comment.
have updated everything to work with latest testnet version !
note-send-proof/circuits/Nargo.toml
Outdated
|
|
||
| [dependencies] | ||
| aztec = { git = "https://github.com/AztecProtocol/aztec-packages/", tag = "v0.87.9", directory = "noir-projects/aztec-nr/aztec" } | ||
| uint_note = { git = "https://github.com/AztecProtocol/aztec-packages/", tag = "v0.87.9", directory = "noir-projects/aztec-nr/uint-note" } |
There was a problem hiding this comment.
can this be updated to 2.0.3 as well?
note-send-proof/scripts/package.json
Outdated
| "lint": "eslint ." | ||
| }, | ||
| "dependencies": { | ||
| "@aztec/accounts": "0.87.9", |
critesjosh
left a comment
critesjosh
left a comment
There was a problem hiding this comment.
Some nits, but its working! this is super cool and will be a great reference 🙏
note-send-proof/readme.md
Outdated
| aztec-up @ 2.0.3 | ||
|
|
||
| Steps: | ||
| 1. aztec-nargo compile in circuits/ |
There was a problem hiding this comment.
Can you wrap the commands in backticks (`) so that they show up as code blocks? it makes it more clear
note-send-proof/readme.md
Outdated
| This proves note hash delivery | ||
|
|
||
| Prerequisites: | ||
| aztec-up @ 2.0.3 |
There was a problem hiding this comment.
add a link to the docs on how to install aztec-up
note-send-proof/readme.md
Outdated
| @@ -0,0 +1,16 @@ | |||
| This proves note hash delivery | |||
There was a problem hiding this comment.
Add some more context. Why would someone want to do this? It might be helpful to explain the question that instigated the development of this example.
note-send-proof/readme.md
Outdated
| 1. aztec-nargo compile in circuits/ | ||
| 2. aztec-nargo compile in sample-contract | ||
| 3. aztec-postprocess-contract in sample-contract | ||
| 4. yarn codegen in scripts |
There was a problem hiding this comment.
| 4. yarn codegen in scripts | |
| 4. `yarn && yarn codegen` in ./scripts |
note-send-proof/readme.md
Outdated
| 5. aztec start --sandbox in terminal 2 | ||
| 6. yarn start in scripts | ||
| 7. copy details outputted by step 6 | ||
| 8. yarn dev in vite |
There was a problem hiding this comment.
| 8. yarn dev in vite | |
| 8. `yarn && yarn dev` in ./vite |
note-send-proof/readme.md
Outdated
| 4. yarn copy-target in scripts | ||
| 5. aztec start --sandbox in terminal 2 | ||
| 6. yarn start in scripts | ||
| 7. copy details outputted by step 6 |
There was a problem hiding this comment.
where am i supposed to copy this? continuing through, I see its meant to be copy pasted in the web app, but that isnt clear at this point
Also i see the output in my terminal like this:
Can you log it in a way that makes it easier to copy-paste? as is, when i double click on the value it highlights this whole line
There was a problem hiding this comment.
wdyt about making it so that the "Generate Proof" and "Verify Proof" tabs are shown next to each other, so you dont have to toggle between the pages?
|
Oh 1 more thing, can you create a CI test for this? It may be helpful to look at how its done for aztec-starter https://github.com/AztecProtocol/aztec-starter/tree/main/.github/workflows |
sklppy88
force-pushed
the
proof-of-note-creation
branch
from
1dff5f8 to
a4f082c
Compare
sklppy88
force-pushed
the
proof-of-note-creation
branch
from
a4f082c to
d19e895
Compare
Workflow
things needed to know