Fix setVelocity infinite regress crash#16
Open
Myst1cS04p wants to merge 1 commit intoAxionize:devfrom
Open
Conversation
Added a guard flag to BukkitPlayer.setVelocity and PlayerKnockbackListener.onPlayerVelocity. Hopefully ts guard flag will stop ts plugin from looping endlessly and crashing the server
Owner
|
What crash? Why is velocity infinite? Do you have reproductions steps for me? |
Author
|
I did ts a while ago so I'm not even sure what happened. No clue how to replicate, all I know is that the velo gets set to infinity sometimes and crashes the server. There's a full traceback below, but I ran ts on my server and it seemed stable so I opened the pr. Callback: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a guard flag to BukkitPlayer.setVelocity and PlayerKnockbackListener.onPlayerVelocity.
Hopefully ts guard flag will stop ts plugin from looping endlessly and crashing the server