Holiday snow: remove from Calypso

[jeherve]

Fixes DOTCOM-15519

Proposed Changes

We should be able to remove the holiday snow settings from Calypso and MSD, and only leave one place where one could manage their holiday snow settings: WP Admin > Settings > General.

Why are these changes being made?

Related conversation: pfsHM7-1H1-p2

Testing Instructions

• Go to http://calypso.localhost:3000/v2/sites/yoursite.wordpress.com/settings
  • You should not see a Holiday Snow setting
• Go to http://calypso.localhost:3000/sites/yoursite.wordpress.com/settings/
  • You should not see a Holiday snow setting
• Go to https://yoursite.wordpress.com/wp-admin/options-general.php
  • You should see the Holiday snow setting if your site's timezone is set to a city in the northern hemisphere.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-164639

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-164639&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-164639&env=a8c-for-agencies

Dashboard live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-164639&env=dashboard

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• help-center
• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug rm/holiday-snow on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~96 bytes removed 📉 [gzipped])

name                    parsed_size           gzip_size
entry-dashboard-dotcom       -685 B  (-0.0%)      -96 B  (-0.0%)
entry-dashboard-ciab         -685 B  (-0.0%)      -96 B  (-0.0%)
entry-subscriptions          -198 B  (-0.0%)      -50 B  (-0.0%)
entry-stepper                -198 B  (-0.0%)      -50 B  (-0.0%)
entry-reauth-required        -198 B  (-0.0%)      -50 B  (-0.0%)
entry-main                   -198 B  (-0.0%)      -50 B  (-0.0%)
entry-login                  -198 B  (-0.0%)      -50 B  (-0.0%)
entry-domains-landing        -198 B  (-0.0%)      -50 B  (-0.0%)
entry-browsehappy            -198 B  (-0.1%)      -50 B  (-0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~452 bytes removed 📉 [gzipped])

name                parsed_size           gzip_size
sites-dashboard         -1873 B  (-0.1%)     -419 B  (-0.0%)
site-settings           -1873 B  (-0.1%)     -419 B  (-0.1%)
hosting                 -1873 B  (-0.1%)     -419 B  (-0.1%)
overview                 -780 B  (-0.0%)      -79 B  (-0.0%)
staging-site             -487 B  (-0.0%)      -46 B  (-0.0%)
site-performance         -487 B  (-0.0%)      -46 B  (-0.0%)
site-monitoring          -487 B  (-0.0%)      -46 B  (-0.0%)
site-logs                -487 B  (-0.0%)      -46 B  (-0.0%)
plans                    -487 B  (-0.0%)      -46 B  (-0.0%)
github-deployments       -487 B  (-0.0%)      -46 B  (-0.0%)
domains                  -487 B  (-0.0%)      -46 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~32 bytes removed 📉 [gzipped])

name                       parsed_size           gzip_size
async-load-v-2-sites-list       -293 B  (-1.6%)      -32 B  (-0.8%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.