vip import media: Improvements in wording and progress bar #2704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the user experience for the vip import media command by providing more accurate wording and implementing a better progress bar for local file uploads.
Changes:
- Updated confirmation message to use "Archive Path" instead of "Archive URL" when importing from a local file
- Replaced confirmation message text to use "the path" instead of "the URL" when appropriate
- Implemented a single-line overwriting progress bar for upload progress instead of printing each percentage on a new line
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/lib/cli/command.js | Detects whether the import source is a URL or local path and adjusts the confirmation message label and text accordingly |
| src/bin/vip-import-media.js | Implements a single-line progress bar that overwrites itself during file upload, preventing duplicate progress messages and improving readability |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the handling of the
import-mediacommand insrc/lib/cli/command.jsto improve user feedback and confirmation messaging based on whether the provided source is a URL or a local file path.Pull request checklist
New release checklist
Steps to Test
Outline the steps to test and verify the PR here.
Example:
npm run build./dist/bin/vip-cookies.js nom