Always use LOCALAPPDATA to generate Windows CLI install path

[fredrikekelund]

Related issues

• Fixes STU-1249

Proposed Changes

As noted by @gcsecsey in #2463 (comment), CLI installation doesn't work when the app was installed using an AppX installer on Windows.

When Studio installs the CLI on Windows, it writes a "proxy studio.bat file" to a directory relative to its installation directory (as determined by the value Electron returns from app.getPath( 'exe' ). However, Microsoft Store installs Studio in a directory like C:\Program Files\WindowsApps\22490Automattic.StudiobyWordPress.com_1.6.8.0_arm64__9h07f78gwnchp that has heavy read and write limitations. Therefore, we believe the CLI installation fails because Studio cannot write the file.

This PR solves the problem by always writing the proxy batch file to a known stable location in %LOCALAPPDATA%.

Testing Instructions

I haven't figured out how to install an AppX dev build on Windows, so code review might have to suffice

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors?

[fredrikekelund]

This Sentry issue confirms our theory. It was triggered by me and the error message reads:

Error: EPERM: operation not permitted, mkdir 'C:\Program Files\WindowsApps\22490Automattic.StudiobyWordPress.com_1.6.8.0_arm64__9h07f78gwnchp\bin'

[fredrikekelund]

An obvious question is, how do we know that process.env.LOCALAPPDATA is defined? Well, there's no official guarantee, and I can't find any Microsoft documentation on this, but it appears the system sets this variable for each process. It's not editable by users either, AFAICT. That's probably as good a guarantee as we'll get.

Still, it makes sense to ensure that we handle errors thrown from here gracefully, so I'll take a look at that now…

[fredrikekelund]

Done in b942405

[wpmobilebot]

📊 Performance Test Results

Comparing 61e372a vs trunk

site-editor

Metric	trunk	61e372a	Diff	Change
load	2863.00 ms	2887.00 ms	+24.00 ms	🔴 0.8%

site-startup

Metric	trunk	61e372a	Diff	Change
siteCreation	7104.00 ms	7072.00 ms	-32.00 ms	🟢 -0.5%
siteStartup	3923.00 ms	3933.00 ms	+10.00 ms	🔴 0.3%

---

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

[gcsecsey]

This LGTM and I can consistently see the toggle working correctly now, both on Parallels and on x64. 👍

When trying to open a Command Prompt using the button on the site details page, I see an Access denied message when I try to use the studio command.

Opening a new tab and using the command in a different directory also prints the same message:

The contents of the bat file seems correct to me, I think the issue might be that we don't have rights to run the batch file under WindowsApps:

@echo off
"C:\Program Files\WindowsApps\22490Automattic.StudiobyWordPress.com_1.6.8.0_arm64__9qb1eemr42qj0\app\resources\bin\studio-cli.bat" %*

[fredrikekelund]

I think the issue might be that we don't have rights to run the batch file under WindowsApps

That seems like a good theory. We probably lack permission to execute that file (but we can read it).

I'm not immediately sure what the best way to solve that is…