Studio: Remove deprecated PHP versions 7.2 and 7.3#2446
Closed
Studio: Remove deprecated PHP versions 7.2 and 7.3#2446
Conversation
These PHP versions are no longer supported and cause timeout errors when creating sites. This removes them from both the UI and CLI.
Contributor
|
Closing it in favor of #2499 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
SupportedPHPVersionsarray incommon/types/php-versions.tscommon/types/php-versionsinstead of@php-wasm/universalfor PHP version typescli/commands/site/create.tsto import from common typescli/commands/site/set.tsto import from common typescli/lib/utils.tsto import from common typesThese PHP versions are no longer supported by WordPress Playground and cause timeout errors when attempting to create sites.
Testing Instructions
npm run cli:build && npm startnpm run cli:build && node dist/cli/main.js site create --name test-site --php 8.3site createcommand does not accept--php 7.2or--php 7.3optionsPre-merge Checklist