checks: trash icon on the open check bails back to project view#206
Merged
Conversation
The trash icon next to a check in the sidebar previously deleted the file but left the editor showing a stale, now-deleted document. Match the three-dot menu's Delete: when the deleted check is the one open in the middle, call onBack() so the user lands back in the project view. Pin the sidebar to the Checks tab first so the panel stays open across the transition — the project view's sidebar now persists its open/tab state to ui-prefs the same way the editor does. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
a0ebd63 to
aa1c29a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses @oandregal's follow-up on #196.
DraftEditorScreennow callsonBack()after a successful delete (matching the three-dot menu).onSidebarOpenChange(true)/onSidebarTabChange('checks')so the panel stays open across the transition. (Sidebar open/tab state already lives inApp.tsxsince Persist right-panel state across project ↔ editor navigation #212, so the transition is smooth without touchinguiPrefsdirectly.)useProjectChecks.handleDeleteChecknow returns the IPC result so the editor can react to success / failure.Test plan
🤖 Generated with Claude Code