Conversation
This is too much indirection. Backends have led to a few bugs by being confusing, and there is zero benefit to such an abstraction. It's only added LOC and more jumping around files to figure out what's happening. IIRC backends were added with the intent to have framebuffer backends but that never got merged because it's way out of scope. I broke the JS ctors in ce29f69 so we got lucky and don't have to call this a breaking change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes a refactor to greatly simplify code: remove backends. I pulled this from the
nextbranch where v4 is being developed and cleaned it up a bit. For that reason I'm going to let this sit a bit and hope I get some review or have time to review myself, then I'll merge it.Fixes #2538
Closes #2552