Fix compilation on GCC 15 by including <cstdint> #2546
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the GCC 15 porting guide, section "Header dependency changes": https://gcc.gnu.org/gcc-15/porting_to.html#header-dep-changes > Some C++ Standard Library headers have been changed to no longer include other headers that were being used internally by the library. As such, C++ programs that used standard library components without including the right headers will no longer compile. > > In particular, the following headers are used less widely within libstdc++ and may need to be included explicitly when compiling with GCC 15: > > `<stdint.h>` (for `int8_t`, `int32_t` etc.) and `<cstdint>` (for `std::int8_t`, `std::int32_t` etc.) > `<ostream>` (for `std::endl`, `std::flush` etc.) `<cstdint>` must now be explicitly included to use these types and was missing from `CharData.h`.
skooch
changed the title
Contributor
Author
|
@chearon No rush, but when would we expect a release to be cut after merging this? Just want to know when I should check back, since I have compiler flags littered in builds at work. |
Collaborator
|
I plan to be working on node-canvas next week, and I can do a patch release then. No release is quick to do until we get our prebuilds overhauled 😕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the GCC 15 porting guide, section "Header dependency changes": https://gcc.gnu.org/gcc-15/porting_to.html#header-dep-changes
<cstdint>must now be explicitly included to use these types and was missing fromCharData.h.This resolves issue #2545
Thanks for contributing!