Functions/DynamicCalls: various minor improvements#862
Merged
Conversation
... to raise code coverage.
The `$stackPtr` is not being changed in the functions using it, so there is no need to store it, it can just be passed as a parameter.
For a `findNext()` to find the first non-empty token, limiting to the "current statement" is not really necessary as it will stop quickly anyway.
Stabilize the "find end of statement" search. After all, assignments may end on a comma or various other tokens too. Includes two tests to demonstrate the bug.
GaryJones
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functions/DynamicCalls: move parse error test to own file
Functions/DynamicCalls: add extra test
... to raise code coverage.
Functions/DynamicCalls: remove unnecessary property
The
$stackPtris not being changed in the functions using it, so there is no need to store it, it can just be passed as a parameter.Functions/DynamicCalls: minor tweak
For a
findNext()to find the first non-empty token, limiting to the "current statement" is not really necessary as it will stop quickly anyway.Functions/DynamicCalls: bug fix - better end of statement determination
Stabilize the "find end of statement" search. After all, assignments may end on a comma or various other tokens too.
Includes two tests to demonstrate the bug.
Also see my remarks in #517.