Conversation
Add tests with: * Variations of namespaced class names. * Anonymous classes extending. * Group exclusion, as supported via the extended abstract.
The `AbstractClassRestrictionsSniff` class does quite a lot of processing before passing off to the `process_matched_token()` method, which can cause quite some overhead for a sniff like this, which is only interested in a class being extended, so let's make it so this sniff only listens to the `T_EXTENDS` token. This should make the sniff significantly faster.
Not strictly necessary, but improves the code readability a little.
jrfnl
added
Type: Maintenance
PHPCSUtils
GaryJones
approved these changes
Jul 23, 2025
GaryJones
deleted the
feature/classes-restrictedextendclasses-sniff-review
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Classes/RestrictedExtendClasses: improve the tests
Add tests with:
Classes/RestrictedExtendClasses: efficiency fix
The
AbstractClassRestrictionsSniffclass does quite a lot of processing before passing off to theprocess_matched_token()method, which can cause quite some overhead for a sniff like this, which is only interested in a class being extended, so let's make it so this sniff only listens to theT_EXTENDStoken.This should make the sniff significantly faster.
Classes/RestrictedExtendClasses: minor tweak
Not strictly necessary, but improves the code readability a little.
Closes #510