Updating generator to fix PHP74 related bug#395
Updating generator to fix PHP74 related bug#395gnongsie merged 1 commit intoAuthorizeNet:php-version-upgradefrom
Conversation
|
Greetings! I see this has been approved already, and I've tested this fix successfully locally. Any idea when this will go out in a release for composer installs as I'd really love to start running PHP 7.4 in my production environment. This is the only library holding me up ATM. Great work and Thanks! |
|
I'm in the same boat. It would be a great help to see this in a release soon. Thanks so much! |
|
@TCURT15 could you please merge this pull request. we have issues with php 7.4 version and waiting for this fix to be released. |
|
waiting for this fix, please merge it in |
|
@TCURT15 please! could you please merge this pull request? it's important! |
|
I do not have the permission nor ability to merge the pull request. I accidentally approved the changes when looking at them. I am in the same boat as everyone else. |
|
@funkjedi are you planning on doing a similar fix for PHP 8.0? It looks like this fixes it on 7.4, but for some reason the parent error comes back in php 8.0. |
With PHP74 deprecation warnings are thrown when using any of the generated classes which don't have parents.
This updates the generator to check if the class is a subclass when appending the jsonSerialize method.
#382 #383