fix(common): show hidden playlists via permalink for logged-out users#14374
Closed
dylanjeffers wants to merge 1 commit into
Closed
fix(common): show hidden playlists via permalink for logged-out users#14374dylanjeffers wants to merge 1 commit into
dylanjeffers wants to merge 1 commit into
Conversation
The backend filters out is_private playlists from permalink lookups for anonymous users, but ID-based lookups bypass that filter. When a permalink lookup returns nothing, retry with the id encoded in the slug so anyone with the direct link can view the playlist. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Contributor
🌐 Web preview readyPreview URL: https://audius-web-preview-pr-14374.audius.workers.dev Unique preview for this PR (deployed from this branch). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_private) playlist were getting a not-found page. The backend filters out private playlists from permalink lookups for anonymous users, but ID-based lookups honor direct-link access.permalink === permalinkcheck guards against id-in-slug collisions.Test plan
packages/commonvitest🤖 Generated with Claude Code