Merged
Conversation
Contributor
rickyrombo
commented
Feb 24, 2026
rickyrombo
commented
- Updates vitest and adds vitest config so that vscode can see the tests for easier integration/debugging
- Fixes return types of entity manager versions
- Fixes mocks to not mock the pure functions from the uploadhelpers
- Fixes uploadAlbum to return albumId not playlistId
- Fixes createPlaylist to allow setting playlistContents
- Fixes updateTrack to allow uploading cover art changes
🦋 Changeset detectedLatest commit: 6bf606d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
raymondjacobson
approved these changes
Feb 24, 2026
| "typed-emitter": "2.1.0", | ||
| "typescript": "5.4.5", | ||
| "vitest": "2.1.1", | ||
| "vitest": "3.2.4", |
Member
There was a problem hiding this comment.
wow surprised this was not too difficult to go that many versions up
Contributor
Author
There was a problem hiding this comment.
some of our other packages us 0.37 😨
| success: true, | ||
| transactionHash: res.transactionHash | ||
| } | ||
| return await this.recordTrackDownloadWithEntityManager(params) |
Member
There was a problem hiding this comment.
what was this success: true used for before? (if anything)
Contributor
Author
There was a problem hiding this comment.
it wasn't - it was added by dumb AI. The original method returned the entity manager response before the refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.