claude/fix-balance-history-daily-Lvhfp#764
Merged
dylanjeffers merged 2 commits intomainfrom Apr 14, 2026
Merged
Conversation
The daily granularity query was summing balance_usd across every hourly snapshot in the day, inflating the result by ~24x. Each hourly row is a point-in-time portfolio snapshot, not an additive quantity, so summing across hours is wrong. Sum across mints per hour first, then pick the latest-hour snapshot of each day as the end-of-day balance.
The SELECT aliased bucket_timestamp AS timestamp, so the secondary ORDER BY timestamp DESC resolved to the alias (a constant within each bucket) instead of the source row's timestamp. DISTINCT ON then picked an arbitrary hour per day. Rename the underlying column to source_timestamp in the CTE so the ORDER BY references it unambiguously and end-of-day is selected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daily granularity query was summing balance_usd across every hourly
snapshot in the day, inflating the result by ~24x. Each hourly row is a
point-in-time portfolio snapshot, not an additive quantity, so summing
across hours is wrong.
Sum across mints per hour first, then pick the latest-hour snapshot of
each day as the end-of-day balance.