Skip to content

Add documentation for getBulkPlaylists to accept permalinks, remove getPlaylistByHandleAndSlug from docs#678

Open
rickyrombo wants to merge 2 commits intomainfrom
mjp-playlists-by-permalink-docs
Open

Add documentation for getBulkPlaylists to accept permalinks, remove getPlaylistByHandleAndSlug from docs#678
rickyrombo wants to merge 2 commits intomainfrom
mjp-playlists-by-permalink-docs

Conversation

@rickyrombo
Copy link
Contributor

breaking change for sdk generation, but I think we should def move away from these "by_permalink"/"by-permalink" variants and just use the root v1/playlists endpoint w/ permalink query parameters. I actively want to remove the existing "ByHandleAndSlug" because it confused the AI

Copy link
Member

@raymondjacobson raymondjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't our client use by_permalink w/ handle + slug though?

@rickyrombo
Copy link
Contributor Author

doesn't our client use by_permalink w/ handle + slug though?

@raymondjacobson yeah i think so, and maybe embed player does to. I'll be sure to update them when doing the client side change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants