Skip to content

Fix typo, remove global var, modernize previews #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
systemblueteam wants to merge 1 commit into from
+7 −13
Closed

Fix typo, remove global var, modernize previews #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Demo/Shared/ContentView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,6 @@ struct ContentView: View {
}
}

struct ContentView_Previews: PreviewProvider {
static var previews: some View {
ContentView()
}
#Preview {
ContentView()
}
14 changes: 5 additions & 9 deletions Sources/Keyboard/MIDIMonitorKeyboard.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public struct MIDIMonitorKeyboard: View {
relativeBlackKeyWidth: relativeBlackKeyWidth,
relativeBlackKeyHeight: relativeBlackKeyHeight)
default:
print("Unimplimented")
print("Unimplemented")
}
}

Expand Down Expand Up @@ -89,14 +89,10 @@ public struct MIDIMonitorKeyboard: View {
}
}

var p = PitchSet(pitches: [Pitch(65), Pitch(68), Pitch(71), Pitch(74)])

// Removing Preview macro until Xcode 15 is released
/*
#Preview {
MIDIMonitorKeyboard(layout: .piano(pitchRange: Pitch(61)...Pitch(88)),
activatedPitches: p,
colorFunction: { x in Color(cgColor: PitchColor.helmholtz[Int(x.pitchClass)])}
MIDIMonitorKeyboard(
layout: .piano(pitchRange: Pitch(61) ... Pitch(88)),
activatedPitches: PitchSet(pitches: [Pitch(65), Pitch(68), Pitch(71), Pitch(74)]),
colorFunction: { pitch in Color(cgColor: PitchColor.helmholtz[Int(pitch.pitchClass)]) }
).frame(width: 600, height: 100)
}
*/
Loading