fix(demo): correct directory rename operation in DemonstrateVFS#131
Open
fix(demo): correct directory rename operation in DemonstrateVFS#131
Conversation
Fixes #130 The RenameDirectory method signature takes (VFSDirectoryPath, string), not (VFSDirectoryPath, VFSDirectoryPath). Updated the demo to use the correct method signature. Changes: - Uncommented the directory rename step - Fixed second parameter to be a string ('heroes') instead of VFSDirectoryPath - Removed TODO comment Tests: All 379 unit tests + 71 GitHub tests pass on net10.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #130
Problem
The
RenameDirectorydemo step was commented out with a TODO because it was using the wrong method signature. The method signature isRenameDirectory(VFSDirectoryPath, string), notRenameDirectory(VFSDirectoryPath, VFSDirectoryPath).Solution
"heroes") instead of aVFSDirectoryPathTesting
✅ All 379 unit tests pass on net10.0
✅ All 71 GitHub tests pass on net10.0
✅ Build succeeds with 0 errors
Changes
The directory rename operation now works correctly in the demo CLI.