Open
Conversation
satouriko
commented
Oct 26, 2021
| instruction = line; | ||
| def << "source = \"" << instruction << "\";" << std::endl; | ||
| continue; | ||
| } |
Author
There was a problem hiding this comment.
Don't know what these codes are used for.
Author
|
Note that this proposed fix is just a compromise that fixes the case that C code with " and \ doesn't compile. In general I don't think the code should be generated like this, line by line, scanning for specific strings, and outputting trivial string combinations. A lot of legal C code will break it, For example, printf("DigitalWrite_High(");It doesn't work if a code doesn't organize as one statement per line, but also valid C code, DigitalWrite_High(1); Delay(5000); DigitalWrite_Low(1);or DigitalWrite_High(
1);
Delay(
5000);
DigitalWrite_Low(
1);Here are 2 possible ways to essentially solve the problem,
I don't think 2 is what we want, so I would suggest 1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C code that contains " doesn't compile,
Example: https://paste.gnome.org/pxirr2vvf