Conversation
WalkthroughThis pull request adds an ABCLikeProvider and registers an "ABC-Like" provider group, extends ARC_LIKE contest mappings (tenka1-2017, tenka1-2019, caddi2018), augments task and contest-task datasets, expands tests for ABC-Like behavior, and updates documentation with concrete provider/test guidance. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Fix all issues with AI agents
In `@docs/guides/how-to-add-contest-table-provider.md`:
- Around line 80-81: Update the broken relative links in
docs/guides/how-to-add-contest-table-provider.md that currently use "../src/..."
so they point to the repository root src directory by using "../../src/..."
(i.e., change the link targets from "../src/..." to "../../src/..."); search for
all occurrences of the "../src/" pattern (including the instances referenced
around the Provider implementation link and the other occurrences noted) and
adjust them to "../../src/" so they resolve correctly from the docs/guides
directory.
- Around line 283-294: Replace the bolded step labels (**ステップ1: データソース確認**,
**ステップ2: ContestType 確認**, **ステップ3: テストデータ構築**) with proper Markdown headings
(e.g., "### ステップ1: データソース確認", etc.) so they are recognized as section headers by
markdownlint MD036; ensure the content under each heading remains unchanged and
keep references to the files and symbols mentioned (prisma/tasks.ts,
prisma/contest_task_pairs.ts, prisma/schema.prisma, src/lib/types/contest.ts,
classifyContest(), ContestType) so links/searches still find them.
In `@prisma/tasks.ts`:
- Around line 7889-7914: Update the inconsistent task id prefixes for the CADDi
2018 Beginners entries: change the ids currently set as 'caddi2018_a' and
'caddi2018_b' (the entries with name 'Product and GCD' and 'Harlequin') to use
the 'caddi2018b_' prefix so they match the rest of the contest (e.g.,
'caddi2018b_c' and 'caddi2018b_d' as appropriate); modify only the id fields in
the task objects so test expectations (which expect 'caddi2018b_*') and task
lookup/merge logic align with the other contest entries ('caddi2018b_a',
'caddi2018b_b', etc.).
In `@src/test/lib/services/task_results.test.ts`:
- Around line 283-299: The mock entry for id '24' uses the wrong task id/index
for ABC422; replace the incorrect 'task_id: "abc422_h"' and 'task_table_index:
"H"' with the correct ABC422 values (e.g., 'task_id: "abc422_g"' and
'task_table_index: "G"') in the test data in task_results.test.ts so the mock
matches real contest layout and avoids masking mismatches.
close #2840
Summary by CodeRabbit
Documentation
New Features
Tests
✏️ Tip: You can customize this high-level summary in your review settings.