Skip to content

fix:修复了添加自定义报错反而会漏报#7113

Open
piexian wants to merge 1 commit intoAstrBotDevs:masterfrom
piexian:fix/non-streaming-custom-error-yield
Open

fix:修复了添加自定义报错反而会漏报#7113
piexian wants to merge 1 commit intoAstrBotDevs:masterfrom
piexian:fix/non-streaming-custom-error-yield

Conversation

@piexian
Copy link
Copy Markdown
Contributor

@piexian piexian commented Mar 28, 2026

当人格配置了自定义报错文案后,在非流式响应模式下,LLM 请求失败时用户仍然看不到自定义报错,甚至看不到任何报错信息。根因:run_agent() 的异常处理分支中,非流式路径只调用了 set_result() 设置错误结果,但缺少 yield,导致 Pipeline 调度器不会执行 RespondStage 发送该结果。消息被静默丢弃。而流式路径有 yield,不存在此问题

Modifications / 改动点

修改 astrbot/core/astr_agent_run_util.py:在 run_agent() 异常处理的非流式分支中,set_result() 之后添加 yield,使调度器能将错误结果交付 RespondStage 发送给用户。

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果


Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txtpyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Bug Fixes:

  • Fix missing error messages in non-streaming responses when LLM requests fail and custom error text is configured.

Copilot AI review requested due to automatic review settings March 28, 2026 20:15
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 28, 2026
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In the non-streaming error branch, consider yielding a consistent value (e.g., an empty MessageChain or the same MessageChain().message(err_msg)) instead of a bare yield so that downstream consumers don’t unexpectedly receive None while the streaming branch yields a message.
  • Add a short comment above the added yield explaining that it’s required to trigger the pipeline scheduler and deliver the error result to RespondStage, so future refactoring doesn’t accidentally remove it.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In the non-streaming error branch, consider yielding a consistent value (e.g., an empty `MessageChain` or the same `MessageChain().message(err_msg)`) instead of a bare `yield` so that downstream consumers don’t unexpectedly receive `None` while the streaming branch yields a message.
- Add a short comment above the added `yield` explaining that it’s required to trigger the pipeline scheduler and deliver the error result to `RespondStage`, so future refactoring doesn’t accidentally remove it.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@dosubot dosubot bot added the area:core The bug / feature is about astrbot's core, backend label Mar 28, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a pipeline delivery gap where, in non-streaming agent runs, an LLM failure would set an error result on the event but never yield, so downstream stages (notably RespondStage) wouldn’t run and the error message could be silently dropped.

Changes:

  • Add a missing yield after astr_event.set_result(...) in run_agent()’s non-streaming exception path so the scheduler can execute downstream stages and send the error to the user.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the run_agent function in astrbot/core/astr_agent_run_util.py by adding a yield statement after setting the result on an event in the error handling path. This change ensures the asynchronous generator yields control back to the caller in this specific execution path. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:core The bug / feature is about astrbot's core, backend size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants