Open
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In the non-streaming error branch, consider yielding a consistent value (e.g., an empty
MessageChainor the sameMessageChain().message(err_msg)) instead of a bareyieldso that downstream consumers don’t unexpectedly receiveNonewhile the streaming branch yields a message. - Add a short comment above the added
yieldexplaining that it’s required to trigger the pipeline scheduler and deliver the error result toRespondStage, so future refactoring doesn’t accidentally remove it.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the non-streaming error branch, consider yielding a consistent value (e.g., an empty `MessageChain` or the same `MessageChain().message(err_msg)`) instead of a bare `yield` so that downstream consumers don’t unexpectedly receive `None` while the streaming branch yields a message.
- Add a short comment above the added `yield` explaining that it’s required to trigger the pipeline scheduler and deliver the error result to `RespondStage`, so future refactoring doesn’t accidentally remove it.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a pipeline delivery gap where, in non-streaming agent runs, an LLM failure would set an error result on the event but never yield, so downstream stages (notably RespondStage) wouldn’t run and the error message could be silently dropped.
Changes:
- Add a missing
yieldafterastr_event.set_result(...)inrun_agent()’s non-streaming exception path so the scheduler can execute downstream stages and send the error to the user.
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the run_agent function in astrbot/core/astr_agent_run_util.py by adding a yield statement after setting the result on an event in the error handling path. This change ensures the asynchronous generator yields control back to the caller in this specific execution path. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
当人格配置了自定义报错文案后,在非流式响应模式下,LLM 请求失败时用户仍然看不到自定义报错,甚至看不到任何报错信息。根因:run_agent() 的异常处理分支中,非流式路径只调用了 set_result() 设置错误结果,但缺少 yield,导致 Pipeline 调度器不会执行 RespondStage 发送该结果。消息被静默丢弃。而流式路径有 yield,不存在此问题
Modifications / 改动点
修改 astrbot/core/astr_agent_run_util.py:在 run_agent() 异常处理的非流式分支中,set_result() 之后添加 yield,使调度器能将错误结果交付 RespondStage 发送给用户。
Screenshots or Test Results / 运行截图或测试结果
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Bug Fixes: