fix(bazel): ensure FTXUI is publicly accessible and add external smoke test #1157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the Bazel build configuration to make FTXUI properly consumable from external workspaces using Bzlmod, and adds integration tests to prevent regressions.
Problem
The previous alias target for
:ftxuidid not properly re-export headers from the underlying modules (component,dom,screen), causing compilation failures when external projects tried to consume as@ftxui//:ftxui:error: module //:smoke does not depend on a module exporting 'ftxui/dom/elements.hpp'Solution
Changed the top-level
:ftxuitarget from a simplealiasto aftxui_cc_librarythat explicitly re-exports all public headers usingglob(["include/ftxui/**/*.hpp"]). This ensures downstream consumers can access all FTXUI headers through the single@ftxui//:ftxuidependency.Created
bazel_integrationas a minimal external workspace that:bazel_dep(name = "ftxui")Includes a smoke test that exercises all three modules
@ftxui//:ftxuiworks as a single dependencyAdded a new CI job that builds the smoke test using:
This prevents future regressions in external visibility or API accessibility.
Testing