refactor: use big decimal when formatting units#189
Merged
ItsANameToo merged 2 commits intofeat/mainsailfrom Mar 10, 2026
Merged
refactor: use big decimal when formatting units#189ItsANameToo merged 2 commits intofeat/mainsailfrom
ItsANameToo merged 2 commits intofeat/mainsailfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors unit formatting to use Brick\Math\BigDecimal instead of float, improving precision and avoiding float rounding issues when converting from wei to gwei/ark.
Changes:
- Update
UnitConverter::formatUnits()to returnBigDecimaland perform division viaBigDecimal::dividedBy(...). - Expand
UnitConverterTestcoverage forformatUnits()using data providers and string comparisons.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/Utils/UnitConverter.php |
Switch formatUnits() from bcdiv()+float to BigDecimal division and return type. |
tests/Unit/Utils/UnitConverterTest.php |
Update/expand tests to validate exact decimal string outputs from formatUnits(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ItsANameToo
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://app.clickup.com/t/86e00vrp2
Checklist