Feat/54 정책, 클라이언트 settings 정보 조회 api 구축#55
Merged
jinwon1234 merged 18 commits intomainfrom Mar 29, 2026
Merged
Conversation
jinwon1234
reviewed
Mar 25, 2026
Collaborator
jinwon1234
left a comment
There was a problem hiding this comment.
고생하셨습니다~ 몇가지 질문이있는데 확인해주세요!
| @NotNull(message = "약관 동의 목록은 필수입니다.") | ||
| List<AgreementItem> agreements | ||
| ) { | ||
| public record AgreementItem( |
Collaborator
There was a problem hiding this comment.
오.. 굳이 내부에 둬야하는 이유가 있을까요??
Collaborator
Author
There was a problem hiding this comment.
음 이유는 딱히 없어요 단일 객체로도 쓰이는 것 같아서 AgreementItem 별도로 파일 분리하는 게 더 낫겠네요
| private final UserInitSettingRepository initSettingRepository; | ||
|
|
||
| @Transactional(readOnly = true) | ||
| public InitSettingsResponse getInitSettings(Long userId) { |
Collaborator
There was a problem hiding this comment.
오우.. 혹시 이거 작업 흐름에 대해서 설명해주실 수 있나요?
Collaborator
Author
There was a problem hiding this comment.
api가 init_settings라서 여기에 dto 만드는 것 까지 다 담당하는 형식으로 했었는데 직관적이지가 않네요 앱 버전이랑 약관 따로 가져와서 controller에서 호출해서 조합하는 형태로 바꿔볼게요
Collaborator
Author
|
조금 더 직관적으로 리팩토링 해봤습니다! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경점 👍
비고 ✏