fix: remove UIImplementation usage from SafeAreaView#730
Merged
Conversation
UIImplementation has been deleted from react-native core. The dispatchViewUpdates call was already a no-op (fully stubbed), so removing it along with the waitForReactLayout helper that only existed to synchronize with that dispatch.
janicduplessis
approved these changes
May 18, 2026
Collaborator
janicduplessis
left a comment
There was a problem hiding this comment.
Confirmed this only affects old arch so fine with this.
Contributor
Author
Thanks for merging this @janicduplessis 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I'm looking into removing
UIImplementationfrom react-native core.That class is currently fully subbed and deprecated so calling it has no effect.
This library is still accessing it though.
The
dispatchViewUpdatescall was already a no-op, soremoving it along with the
waitForReactLayouthelper that onlyexisted to synchronize with that dispatch.