feat: add new arch support to macos#591
Merged
janicduplessis merged 3 commits intoAppAndFlow:mainfrom Feb 26, 2025
Merged
Conversation
jacobp100
reviewed
Feb 25, 2025
jacobp100
approved these changes
Feb 25, 2025
Collaborator
jacobp100
left a comment
jacobp100
left a comment
There was a problem hiding this comment.
Thank you! All looks good - just one question if we need to target macOS 11
Collaborator
|
I think this is fine, thanks everyone! |
Collaborator
|
Can you just run yarn format:write to fix formatting lint. |
janicduplessis
approved these changes
Feb 25, 2025
Contributor
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up of #513
While building BareExpo for macOS I noticed that macOS builds are broken when using the new arch. This PR added the necessary platform checks to fix it
Test Plan
Manually added macOS to the sample app so I could test it manually.