Skip to content

Add Media kit & Branding page#236

Closed
keunes wants to merge 3 commits intomasterfrom
media-branding
Closed

Add Media kit & Branding page#236
keunes wants to merge 3 commits intomasterfrom
media-branding

Conversation

@keunes
Copy link
Copy Markdown
Member

@keunes keunes commented May 8, 2023

And publish the first press release.

Note: This PR doesn't (yet) update the GH actions required for translations. A separate PR will be required.

keunes added 2 commits May 10, 2023 22:42
* Remove deprecated strings from translation files
* Update Actions
@keunes
Copy link
Copy Markdown
Member Author

keunes commented May 10, 2023

GH build fails - as does Netlify. Both have the same issue:

Building site for language: "en" to: /home/runner/work/antennapod.github.io/antennapod.github.io/_site
Loading translation from file /home/runner/work/antennapod.github.io/antennapod.github.io/_i18n/en.yml
Missing i18n key: en:<p class="lead">Tuesday 9 May 2023 – The new 3.0 release of the free and ad-free podcast app for Android ‘AntennaPod’ introduces a Home screen, giving users an overview of the most important sections and content in the app. This new version will land in users’ hands with a refreshed icon and interface. The updated app is available for download on Google Play and F-Droid from today.</p>
  Liquid Exception: no implicit conversion of nil into String in /home/runner/work/antennapod.github.io/antennapod.github.io/_layouts/internal.html
                    ------------------------------------------------
      Jekyll 4.3.1   Please append `--trace` to the `build` command 
                     for any additional information or backtrace. 
                    ------------------------------------------------

I don't really understand, though. There are no translations for the whole file - _i18n/en/press-releases/2023-05-08-version-3.md exists only in English. That's not an issue for other files without translation. Maybe the {: .lead} tag is throwing something off?

@ByteHamster
Copy link
Copy Markdown
Member

Sounds like something is trying to translate the already translated blog post title again. I don't know what .lead does.

@keunes
Copy link
Copy Markdown
Member Author

keunes commented May 13, 2023

I don't know what .lead does.

It applies the (lead) class to the element (paragraph) that follows.

@delthia
Copy link
Copy Markdown
Collaborator

delthia commented Feb 14, 2026

PR #460 by @AnXh3L0 added this. Should we close this PR @keunes ?

@keunes
Copy link
Copy Markdown
Member Author

keunes commented Feb 14, 2026

Wow, saw it just now, that's nice! :-)
Wondering if we should add support for 'press releases' still (which apparently I had added). May actually be a bit overkill, given that we're not really writing a lot (at our blog) anyway.

@ByteHamster
Copy link
Copy Markdown
Member

Yeah I would say we can write it on our blog if we want to release something. I think a mostly empty press release section could look worse than no section at all 😅

@keunes keunes closed this Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants