Skip to content

catch errors before exec #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jph00 merged 1 commit into from
Dec 19, 2025
Merged

catch errors before exec #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion execnb/shell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ def _run(self, raw_cell, store_history=False, silent=False, shell_futures=True,
with capture_output(display=display, stdout=stdout and not verbose, stderr=stderr and not verbose) as c:
result = super().run_cell(raw_cell, store_history, silent, shell_futures=shell_futures, cell_id=cell_id)
return AttrDict(result=result, stdout='' if semic else c.stdout, stderr=c.stderr,
display_objects=c.outputs, exception=result.error_in_exec, quiet=semic)
display_objects=c.outputs,
exception=result.error_in_exec or result.error_before_exec, quiet=semic)

def set_path(self, path):
"Add `path` to python path, or `path.parent` if it's a file"
Expand Down
226 changes: 192 additions & 34 deletions nbs/02_shell.ipynb
View file
Open in desktop

Large diffs are not rendered by default.