updated the project to december 2018#3
Open
alexbjorlig wants to merge 3 commits intoAngularFirebase:masterfrom
Open
updated the project to december 2018#3alexbjorlig wants to merge 3 commits intoAngularFirebase:masterfrom
alexbjorlig wants to merge 3 commits intoAngularFirebase:masterfrom
Conversation
ak2g
approved these changes
Dec 24, 2018
|
thank u a lot, it is compiling after some dependencies updates but it wont resize my images lol |
Author
|
Hi @hellseyfer - what error do you get? Maybe you could share your repo? |
I tested with a new upload and it worked but not the old ones |
Author
|
@hellseyfer since this code is "reactive" I would say that's intended behaviour 😄 |
|
Alright, good job~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a PR that targets #2, and several other small issues I found when using this example in december 2018:
Promise.all()Let me know what you think 😎