Skip to content

Conversation

@WolfgangPecho
Copy link
Contributor

CPAN::Mini::Inject::inject() reports only the first module of a dist file if verbose is on. It should
report each injected Module for each dist file.

The line

 next if $already_injected{$file}++; 

prevented printing of other modules.


# if verbose report target file and the modules it contains
if ( $verbose ) {
for my $target (keys %report) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the keys should be sorted? That would make reading the report easier. Since we cannot have them in the order they were done, we can at least have them in some order, rather than random.

@simbabque
Copy link

simbabque commented Sep 29, 2017

@wchristian I've reviewed this PR as part of my Pull Request Challenge entry for September 2017 and think it can be merged without problems. There's the one thing I think could be a bit more convenient, but that's trivial to add.

Updating the documentation might make sense too.

Passing a value to "inject" enables verbose mode, which lists each module as it's injected.

could become something like

Passing a value to "inject" enables verbose mode, which produces a report of all injected modules.

@briandfoy
Copy link
Contributor

briandfoy commented May 23, 2024

I've cherry-picked this into briandfoy/cpan-mini-inject@93b4e0d

@briandfoy
Copy link
Contributor

This is part of 1.002. I can't close this issue though. Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants