added 'skip_cleanup' handling to CPAN::Mini::Inject::update_mirror #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwstauner
referenced
this pull request
in rwstauner/CPAN--Mini--Inject
Jun 14, 2011
Missing dashes before argument in mcpani example
|
@wchristian I've reviewed this PR as part of my Pull Request Challenge entry for September 2017 and think it can be merged without problems. I am not sure if it should have documentation, but then not all of the pass-through options have any, so I think we are good. |
Contributor
|
I've merged this in briandfoy/cpan-mini-inject@b9c6bdf. I would have cherry-picked it but the original repo for the PR is gone. |
briandfoy
added a commit
to briandfoy/cpan-mini-inject
that referenced
this pull request
May 23, 2024
This is from AndyA/CPAN--Mini--Inject#1, but the original repo from the PR is missing so I couldn't cherry pick this. Co-authored-by: matthewdpklanier
Contributor
|
This is now part of 1.002. Thanks. I can't close this issue, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Andy-
CPAN::Mini supports the 'skip_cleanup' flag. In this commit, I add handling for passing 'skip_cleanup' through from the mcpani configuration via CPAN::Mini::Inject::update_mirror to CPAN::Mini. I'm using this internally, and it's working for me. What do you think?
thanks-
Matt Lanier