Refine system prompts — personality, communication protocols, agent routing#38
Merged
AnExiledDev merged 4 commits intomainfrom Feb 27, 2026
Merged
Refine system prompts — personality, communication protocols, agent routing#38AnExiledDev merged 4 commits intomainfrom
AnExiledDev merged 4 commits intomainfrom
Conversation
…press main prompt Main system prompt redesigned from 672 to 462 lines: added personality section with communication style and AuDHD-aware patterns, compressed specification management and code standards, removed browser automation and git worktrees (moved to loadable skills), added mandatory context-passing protocol for subagent spawning, absorbed assumption_surfacing and professional_objectivity into core sections. All 21 agent prompts now have communication protocols — read-only agents get "Handling Uncertainty" (flag assumptions, continue working), write-capable agents get "Question Surfacing Protocol" (BLOCKED + return for ambiguity). Architect agent gains anti-fluff enforcement and team orchestration planning. Generalist rewritten as explicit last-resort fallback. Bash guard hooks added to researcher, debug-logs, and perf-profiler agents.
Address all 10 CodeRabbit review items plus 3 nitpicks: - Fix communication protocol contradictions across 8 agent files (aligned "ask the user" instructions with Handling Uncertainty / Question Surfacing Protocol sections) - Add `text` language identifier to fenced code block in main prompt - Soften architect anti-fluff rule to allow evidence-based rationale in alternatives analysis (was: ban ALL justification) - Merge duplicate ### Changed sections in CHANGELOG under [Unreleased] - Clarify spec-writer BLOCKED section and fix hyphenation Additional changes from approved plan (sessions 2-3): - Main prompt: add delegation-only orchestrator, git workflow discipline, dynamic team sizing, remove artificial teammate caps - Architect: complexity scaling, 20+ banned fluff patterns, edit ordering, rollback strategy, schema detection, 3 new examples - Merge tester→test-writer (absorb 120s timeout, delete tester.md) - Merge doc-writer→documenter (absorb README/API/docstring patterns, add worktree isolation, delete doc-writer.md) - Narrow investigator to cross-domain investigations only - Improve descriptions on 8 agents for routing accuracy - Fix stale doc-writer/tester references across 6 files
- security-auditor: soften dependency boundary from "use X instead" to "prefer X" — agent still has A06 dependency tooling for surface-level checks, which doesn't conflict with a preference statement - dependency-analyst: add Ruby/Gem ecosystem to description (agent already supports Gemfile scanning) - documenter: add `bash` language identifier to fenced code block - generalist: refine Question Surfacing Protocol to distinguish correctness-affecting ambiguity (STOP) from minor ambiguity (proceed with documented assumption)
- documenter: distinguish blocking ambiguity (scope, audience, approval) from non-blocking ambiguity (unclear code → TODO: verify), resolving contradiction between MUST-stop protocol and continue-with-TODO rule - documenter: clarify that hand-written usage examples are encouraged while verbatim source reproduction is forbidden - security-auditor: explicitly state basic dependency scanning is included in comprehensive audits, improving routing clarity
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (28)
📝 WalkthroughWalkthroughThis pull request comprehensively restructures the agent system, reducing agent count from 21 to 19 by consolidating doc-writer into documenter. It rewrites the main system prompt with refined execution guidelines and substantially updates agent documentation with new uncertainty-handling protocols and question-surfacing mechanisms across multiple agents. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
Supersedes #37 (closed due to branch deletion during rebase)
Test plan
Summary by CodeRabbit
Changes
Refactoring