-
Notifications
You must be signed in to change notification settings - Fork 31
PersonLookup: Inform user about lock-out duration #3970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughPersonLookup validation messages in English, Norwegian Bokmål, and Norwegian Nynorsk were updated to state a 3-attempt retry limit and to explicitly mention a one-hour temporary lockout. A test expectation was adjusted to match the updated message. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/publish |
PR release:
|
|
/publish |
PR release:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/language/texts/nn.ts`:
- Around line 346-347: Update the Nynorsk translation for the
'person_lookup.validation_error_too_many_requests' key so the message uses
consistent Nynorsk forms: change "fra" to "frå" and "i en time" to "i ein time",
ensuring the full string reads in Nynorsk (e.g., replace "Du har blitt utestengt
fra søkefunksjonaliteten i en time. Ver venleg, prøv igjen seinare." with the
Nynorsk equivalent using "frå" and "ein").
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
|
/publish |
PR release:
|
walldenfilippa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!



Description
Update the error messages to be more informative.
Hard code as fetching from souce is over-engineering as these are not dynamic values.
Docs is a screenshot of the component, which is why the doc issue is connected here.
Related Issue(s)
Verification/QA
kind/*andbackport*label to this PR for proper release notes groupingSummary by CodeRabbit
Updates
Tests
✏️ Tip: You can customize this high-level summary in your review settings.