feat: show validation value even on clean PRs — compelling UX#6
Merged
anandgupta42 merged 1 commit intomainfrom Mar 25, 2026
Merged
feat: show validation value even on clean PRs — compelling UX#6anandgupta42 merged 1 commit intomainfrom
anandgupta42 merged 1 commit intomainfrom
Conversation
Replace the old "Check | Result | Details" table with a new "What We Checked | How | Result" validation table that communicates what was validated and the technology used (DataFusion, AST analysis, pattern scan, column classification). Key changes: - New `ValidationSummary` and `QueryProfile` types in `types.ts` - `extractValidationSummary()` in `cli-check.ts` with `CATEGORY_META` mapping for all 7 check categories - New `query-profile.ts` module for regex-based SQL structure extraction (complexity, JOINs, CTEs, subqueries, window functions, aggregation) - Rewritten executive line: "validated" instead of "modified", "N downstream safe" instead of "all checks passed", "N findings" instead of separate critical/warning counts - Collapsible Query Profile section with per-file metadata table - Footer now includes "Validated without hitting your warehouse" - Always post comment when `filesAnalyzed > 0` (previously skipped clean PRs, which showed zero value) - `runCheckCommand` now returns `CheckCommandResult` with both issues and validation summary - Version bumped to 0.4.0 - Updated all unit and e2e tests for new format Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Redesigns the PR comment to show VALUE even when all checks pass. The old format said "0 issues" which communicates nothing. The new format shows what was validated, how, and calls out zero-cost warehouse-free analysis.
Before (no value):
After (shows value):
Plus: Query Profile section, "Validated without hitting your warehouse" footer.
Type of change
Stats