Skip to content

feat: add pipeline diagrams#76

Open
arielleleon wants to merge 6 commits into
mainfrom
add-pipeline-svg
Open

feat: add pipeline diagrams#76
arielleleon wants to merge 6 commits into
mainfrom
add-pipeline-svg

Conversation

@arielleleon
Copy link
Copy Markdown
Collaborator

@arielleleon arielleleon commented Apr 8, 2026

  • add pipeline diagrams

@arielleleon arielleleon requested review from bruno-f-cruz, dbirman, jtyoung84 and patricklatimer and removed request for dbirman April 8, 2026 17:54
@arielleleon arielleleon marked this pull request as draft April 9, 2026 20:02
@arielleleon arielleleon marked this pull request as ready for review April 22, 2026 17:26
bruno-f-cruz
bruno-f-cruz reviewed May 11, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@bruno-f-cruz bruno-f-cruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit confused about the diagram. It is not clear how each container processing is related with metadata generated. Is each container expected to generate a new metadata file? should they append to a single one?

@arielleleon
Copy link
Copy Markdown
Collaborator Author

arielleleon commented May 11, 2026

@bruno-f-cruz metadata should be output from each container (processing and quality_control). They get appended at the end. I updated the diagram. Should I add an arrow from each json going to the metadata container?

@arielleleon arielleleon mentioned this pull request May 14, 2026
Closed
@bruno-f-cruz
Copy link
Copy Markdown
Member

bruno-f-cruz commented May 14, 2026

@bruno-f-cruz metadata should be output from each container (processing and quality_control). They get appended at the end. I updated the diagram. Should I add an arrow from each json going to the metadata container?

Can you add some descriptors to arrows that say "appends to" like in here:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bruno-f-cruz bruno-f-cruz bruno-f-cruz left review comments

@jtyoung84 jtyoung84 Awaiting requested review from jtyoung84

@patricklatimer patricklatimer Awaiting requested review from patricklatimer

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arielleleon @bruno-f-cruz