Skip to content

[OGUI-1577] Alert user of no filters set#3440

Merged
graduta merged 7 commits intodevfrom
feature/ILG/OGUI-1577/Alert-user-of-no-filters-set
May 8, 2026
Merged

[OGUI-1577] Alert user of no filters set#3440
graduta merged 7 commits intodevfrom
feature/ILG/OGUI-1577/Alert-user-of-no-filters-set

Conversation

@isaachilly
Copy link
Copy Markdown
Collaborator

@isaachilly isaachilly commented May 8, 2026

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful
  • Adds a method to the filter model to check if any text filters are active.
  • Query handler calls this method and if false opens a confirmation dialog to the user.
  • Does or doesn't execute query based on user's response.
image

isaachilly added 2 commits May 8, 2026 10:08
Adds a method to the filter model which returns true if the user has typed a value in any of the since/until/match/exclude inputs.

Before executing a query, the query handler now calls this method and shows a confirmation dialog if no text filters are set. This prevents accidentally making an unnecessary unbounded query.

Severity and level filters are intentionally excluded from the check as even when selected, the query can still be very large, so they do not count as meaningful constraints.
Adds three tests covering the confirmation dialog behaviour for the no-text-filters warning.
@isaachilly isaachilly self-assigned this May 8, 2026
@isaachilly isaachilly added Frontend InfoLogger javascript Pull requests that update javascript code labels May 8, 2026
@isaachilly isaachilly marked this pull request as ready for review May 8, 2026 08:29
@isaachilly isaachilly requested a review from graduta as a code owner May 8, 2026 08:29
Comment thread InfoLogger/public/log/Log.js Outdated
Comment thread InfoLogger/test/public/query-mode-mocha.js Outdated
@graduta graduta merged commit 89821b3 into dev May 8, 2026
10 checks passed
@graduta graduta deleted the feature/ILG/OGUI-1577/Alert-user-of-no-filters-set branch May 8, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend InfoLogger javascript Pull requests that update javascript code

Development

Successfully merging this pull request may close these issues.

2 participants