Merged
Conversation
Adds a method to the filter model which returns true if the user has typed a value in any of the since/until/match/exclude inputs. Before executing a query, the query handler now calls this method and shows a confirmation dialog if no text filters are set. This prevents accidentally making an unnecessary unbounded query. Severity and level filters are intentionally excluded from the check as even when selected, the query can still be very large, so they do not count as meaningful constraints.
Adds three tests covering the confirmation dialog behaviour for the no-text-filters warning.
graduta
requested changes
May 8, 2026
Removed unneeded check and made if statement cleaner.
graduta
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created