Skip to content

[OGUI-1073] Infologger link can get stuck if provided invalid filter parameters#3439

Merged
isaachilly merged 3 commits intodevfrom
feature/ILG/OGUI-1073/Infologger-link-can-get-stuck
May 8, 2026
Merged

[OGUI-1073] Infologger link can get stuck if provided invalid filter parameters#3439
isaachilly merged 3 commits intodevfrom
feature/ILG/OGUI-1073/Infologger-link-can-get-stuck

Conversation

@isaachilly
Copy link
Copy Markdown
Collaborator

@isaachilly isaachilly commented May 7, 2026

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful

This PR adds a try and catch when the parsing of filter params occurs on location change.

  • It catches the parsing error
  • Resets filters & navigates to the default page
  • Shows a danger notification with JSON line col error message

isaachilly added 2 commits May 7, 2026 19:00
…ms are unparseable

Added a try and catch to check if the URL filter params are parseable, if they are not raise a danger notification stating the JSON error message.
@isaachilly isaachilly self-assigned this May 7, 2026
@isaachilly isaachilly added Frontend InfoLogger javascript Pull requests that update javascript code labels May 7, 2026
Parsing error is engine-specific and CI/CD with Puppeteer uses Chromium by default.
@isaachilly isaachilly marked this pull request as ready for review May 7, 2026 17:39
@isaachilly isaachilly requested a review from graduta as a code owner May 7, 2026 17:39
@isaachilly isaachilly merged commit 71d2dba into dev May 8, 2026
10 checks passed
@isaachilly isaachilly deleted the feature/ILG/OGUI-1073/Infologger-link-can-get-stuck branch May 8, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend InfoLogger javascript Pull requests that update javascript code

Development

Successfully merging this pull request may close these issues.

2 participants