[PWGCF] additional track QA#15340
Merged
victor-gonzalez merged 1 commit intoAliceO2Group:masterfrom Mar 10, 2026
Merged
Conversation
EmilGorm
requested review from
alibuild,
jaelpark,
otonvd,
shouqiye and
victor-gonzalez
as code owners
victor-gonzalez
approved these changes
Mar 10, 2026
vkucera
reviewed
Mar 11, 2026
Comment on lines
+283
to
+284
| TF1* fPhiCutLow; | ||
| TF1* fPhiCutHigh; |
Collaborator
There was a problem hiding this comment.
Always initialise pointers.
vkucera
reviewed
Mar 11, 2026
|
|
||
| template <typename TTrack> | ||
| bool trackSelected(TTrack track) | ||
| bool trackSelected(TTrack track, const int& field) |
Collaborator
There was a problem hiding this comment.
Don't pass int by reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.