Fix Bash syntax issues found by shellcheck (#1482)

TimoWilken · web-flow · commit 6d2d239238e9 · 2024-02-20T13:22:18.000Z
Fix issues found in #1469, in addition to those fixed in #1479.
diff --git a/GRID/utils/extractErroredLogFiles.sh b/GRID/utils/extractErroredLogFiles.sh
@@ -4,13 +4,13 @@
 # Beware that errors might occur outside of O2DPG tasks such as in preprocessing etc or not visible in logs
 
 mytar () {
-  tar $@
+  tar "$@"
 }
 if [[ $(uname) == "Darwin" ]]; then
     echo "Running on macOS. This needs gnu-tar"
     $(which gtar)
     mytar () {
-      gtar $@
+      gtar "$@"
     }
 fi
 
diff --git a/GRID/utils/grid_submit.sh b/GRID/utils/grid_submit.sh
@@ -401,7 +401,7 @@ EOF
   spin[1]="|"
   spin[0]="\\"
   JOBSTATUS="I"
-  if [ "{WAITFORALIEN}" ]; then
+  if [ "${WAITFORALIEN}" ]; then
     echo -n "Waiting for jobs to return ... Last status : ${spin[0]} ${JOBSTATUS}"
   fi
   counter=0

Original file line number	Diff line number	Diff line change
`@@ -4,13 +4,13 @@`
`4`	`4`	`# Beware that errors might occur outside of O2DPG tasks such as in preprocessing etc or not visible in logs`
`5`	`5`
`6`	`6`	`mytar () {`
`7`		`- tar $@`
	`7`	`+ tar "$@"`
`8`	`8`	`}`
`9`	`9`	`if [[ $(uname) == "Darwin" ]]; then`
`10`	`10`	`echo "Running on macOS. This needs gnu-tar"`
`11`	`11`	`$(which gtar)`
`12`	`12`	`mytar () {`
`13`		`- gtar $@`
	`13`	`+ gtar "$@"`
`14`	`14`	`}`
`15`	`15`	`fi`
`16`	`16`