More bash syntax check fixes (#1479)

Author: martenole

DATA/production/calib/mch-badchannel-processing.sh

@@ -1,4 +1,3 @@
-
 #!/bin/bash
 
 source common/setenv.sh

DATA/production/calib/tpc-pulser-long.sh

@@ -1,4 +1,3 @@
-
 #!/usr/bin/env bash
 
 source common/setenv.sh

DATA/production/calib/tpc-pulser.sh

@@ -1,4 +1,3 @@
-
 #!/usr/bin/env bash
 
 source common/setenv.sh

DATA/production/configurations/2021/ctf_recreation/ctf_recreation.sh

@@ -72,7 +72,7 @@ fi
 # if "$DETCONFIG" is set explicitly, this has the second highest priority
 # last option is to have it from the JDL
 if [[ -z "$DETCONFIG" ]]; then
-    if [[ -z "ALIEN_JDL_DETCONFIG" ]]; then
+    if [[ -z "$ALIEN_JDL_DETCONFIG" ]]; then
 	echo "nothing set the detector configuration to use, exiting"
 	exit 4
     else

DATA/production/configurations/2022/LHC22f/apass1/async_pass.sh

@@ -504,7 +504,7 @@ else
 	  echo "nCTFsFilesInspected_step1 = $nCTFsFilesInspected_step1, nCTFsFilesInspected_step2 = $nCTFsFilesInspected_step2" > validation_error.message
 	  echo "nCTFsFilesOK_step1 = $nCTFsFilesOK_step1, nCTFsFilesOK_step2 = $nCTFsFilesOK_step2" > validation_error.message
 	  echo "nCTFsProcessed_step1 = $nCTFsProcessed_step1, nCTFsProcessed_step2 = $nCTFsProcessed_step2" > validation_error.message
-	  exit 1000
+	  exit 255
 	fi
       fi
     fi
@@ -663,7 +663,7 @@ if [[ $ALIEN_JDL_AODOFF != 1 ]]; then
       CURRENT_POOL_SIZE=`jobs -r | wc -l`
     done < $JOB_LIST
     # collecting return codes of the merging processes
-    for i in ${!arr[@]}; do
+    for i in "${!arr[@]}"; do
       wait ${arr[$i]}
       exitcode=$?
       if [[ $exitcode -ne 0 ]]; then