Detectors: make sure fmt 10.1.1 is supported

ktf · ktf · commit 869839689cbd · 2023-11-10T11:03:36.000+01:00
diff --git a/DataFormats/Detectors/Common/include/DetectorsCommonDataFormats/EncodedBlocks.h b/DataFormats/Detectors/Common/include/DetectorsCommonDataFormats/EncodedBlocks.h
@@ -402,7 +402,8 @@ class EncodedBlocks
       if (getANSHeader() == ANSVersionUnspecified) {
         rans::DenseHistogram<source_T> histogram{block.getDict(), block.getDict() + block.getNDict(), metadata.min};
         size_t renormingBits = rans::utils::sanitizeRenormingBitRange(metadata.probabilityBits);
-        LOG_IF(debug, renormingBits != metadata.probabilityBits) << fmt::format("While reading metadata from external dictionary, rANSV1 is rounding renorming precision from {} to {}");
+        LOG_IF(debug, renormingBits != metadata.probabilityBits)
+          << fmt::format("While reading metadata from external dictionary, rANSV1 is rounding renorming precision from {} to {}", metadata.probabilityBits, renormingBits);
         return rans::renorm(std::move(histogram), renormingBits, rans::RenormingPolicy::ForceIncompressible);
       } else {
         // dictionary is elias-delta coded inside the block
diff --git a/DataFormats/Detectors/GlobalTracking/include/DataFormatsGlobalTracking/RecoContainerCreateTracksVariadic.h b/DataFormats/Detectors/GlobalTracking/include/DataFormatsGlobalTracking/RecoContainerCreateTracksVariadic.h
@@ -285,7 +285,7 @@ void o2::globaltracking::RecoContainer::createTracksVariadic(T creator, GTrackID
     if (srcSel[currentSource]) {
       if (matchesTPCTOF.size() && !tracksTPCTOF.size()) {
         throw std::runtime_error(fmt::format("TPC-TOF matched tracks ({}) require TPCTOF matches ({}) and TPCTOF tracks ({})",
-                                             matchesTPCTOF.size(), tracksTPCTOF.size()));
+                                             -1, matchesTPCTOF.size(), tracksTPCTOF.size()));
       }
       for (unsigned i = 0; i < matchesTPCTOF.size(); i++) {
         const auto& match = matchesTPCTOF[i];
@@ -321,7 +321,7 @@ void o2::globaltracking::RecoContainer::createTracksVariadic(T creator, GTrackID
     if (srcSel[currentSource]) {
       if (matchesMCHMID.size() && !tracksMCH.size()) {
         throw std::runtime_error(fmt::format("MCH-MID matched tracks ({}) require MCHMID matches ({}) and MCH tracks ({})",
-                                             matchesMCHMID.size(), tracksMCH.size()));
+                                             -1, matchesMCHMID.size(), tracksMCH.size()));
       }
       for (unsigned i = 0; i < matchesMCHMID.size(); i++) {
         const auto& match = matchesMCHMID[i];
diff --git a/DataFormats/Parameters/src/GRPTool.cxx b/DataFormats/Parameters/src/GRPTool.cxx
@@ -205,7 +205,7 @@ bool publish(std::string const& filename, std::string const& path, std::string C
   try {
     o2::utils::createDirectoriesIfAbsent(targetdir);
   } catch (std::exception e) {
-    LOGP(error, fmt::format("Could not create local snapshot cache directory {}, reason: {}", targetdir, e.what()));
+    LOGP(error, "Could not create local snapshot cache directory {}, reason: {}", targetdir, e.what());
     return false;
   }
 
diff --git a/Detectors/CTF/workflow/src/ctf-reader-workflow.cxx b/Detectors/CTF/workflow/src/ctf-reader-workflow.cxx
@@ -134,7 +134,7 @@ WorkflowSpec defineDataProcessing(ConfigContext const& configcontext)
   int rateLimitingIPCID = std::stoi(configcontext.options().get<std::string>("timeframes-rate-limit-ipcid"));
   std::string chanFmt = configcontext.options().get<std::string>("metric-feedback-channel-format");
   if (rateLimitingIPCID > -1 && !chanFmt.empty()) {
-    ctfInput.metricChannel = fmt::format(chanFmt, o2::framework::ChannelSpecHelpers::defaultIPCFolder(), rateLimitingIPCID);
+    ctfInput.metricChannel = fmt::format(fmt::runtime(chanFmt), o2::framework::ChannelSpecHelpers::defaultIPCFolder(), rateLimitingIPCID);
   }
 
   specs.push_back(o2::ctf::getCTFReaderSpec(ctfInput));
diff --git a/Detectors/DCS/src/AliasExpander.cxx b/Detectors/DCS/src/AliasExpander.cxx
@@ -82,7 +82,7 @@ std::vector<std::string> extractRange(std::string range)
   std::vector<std::string> result;
 
   for (auto i = a; i <= b; i++) {
-    auto substituted = fmt::format(intFormat, i);
+    auto substituted = fmt::format(fmt::runtime(intFormat), i);
     result.push_back(substituted);
   }
   return result;
@@ -124,7 +124,7 @@ std::vector<std::string> expandAlias(const std::string& pattern)
   std::vector<std::string> result;
 
   for (auto r : range) {
-    auto substituted = fmt::format(newPattern, r);
+    auto substituted = fmt::format(fmt::runtime(newPattern), r);
     result.emplace_back(substituted);
   }
 
diff --git a/Detectors/EMCAL/base/src/RCUTrailer.cxx b/Detectors/EMCAL/base/src/RCUTrailer.cxx
@@ -172,7 +172,7 @@ void RCUTrailer::setTimeSamplePhaseNS(uint64_t triggertime, uint64_t timesample)
       sample = 2;
       break;
     default:
-      throw Error(Error::ErrorType_t::SAMPLINGFREQ_INVALID, fmt::format("invalid time sample: {:f}", timesample).data());
+      throw Error(Error::ErrorType_t::SAMPLINGFREQ_INVALID, fmt::format(fmt::runtime("invalid time sample: {:f}"), timesample).data());
   };
   mAltroConfig.mSampleTime = sample;
   // calculate L1 phase
@@ -275,4 +275,4 @@ std::ostream& o2::emcal::operator<<(std::ostream& stream, const o2::emcal::RCUTr
 {
   trailer.printStream(stream);
   return stream;
-}
+}
diff --git a/Detectors/HMPID/calibration/src/HMPIDDCSProcessor.cxx b/Detectors/HMPID/calibration/src/HMPIDDCSProcessor.cxx
@@ -395,7 +395,7 @@ double HMPIDDCSProcessor::calculatePhotonEnergy(int i)
   if (dp.id.get_type() == DeliveryType::DPVAL_DOUBLE) {
     lambda = o2::dcs::getValue<double>(dp);
   } else {
-    LOGP(warn, "DP type is {}", dp.id.get_type());
+    LOGP(warn, "DP type is {}", (int)dp.id.get_type());
     LOGP(warn, "Not correct datatype for HMP_TRANPLANT_MEASURE_{}_WAVELENGTH --> Default wavelength used for iteration procTrans{}", i, i);
     lambda = arrWaveLenDefault[i];
   }
diff --git a/Detectors/ITSMFT/MFT/alignment/src/MillePede2.cxx b/Detectors/ITSMFT/MFT/alignment/src/MillePede2.cxx
@@ -1384,7 +1384,7 @@ int MillePede2::SolveGlobalMatEq()
     if (fgIterSol == MinResSolve::kSolFGMRes) {
       res = slv->SolveFGMRES(sol, fgMinResCondType, fgMinResMaxIter, fgMinResTol, fgNKrylovV);
     } else {
-      LOGF(warning, "MillePede2 - Undefined Iteritive Solver ID=%d, only %d are defined", fgIterSol, MinResSolve::kNSolvers);
+      LOGF(warning, "MillePede2 - Undefined Iteritive Solver ID=%d, only %d are defined", fgIterSol, (int)MinResSolve::kNSolvers);
     }
   }
 
diff --git a/Detectors/ITSMFT/common/reconstruction/src/PixelData.cxx b/Detectors/ITSMFT/common/reconstruction/src/PixelData.cxx
@@ -48,7 +48,7 @@ std::string ChipPixelData::getErrorDetails(int pos) const
     std::string rbuf = ": 0x<";
     int nc = getNBytesInRawBuff();
     for (int i = 0; i < nc; i++) {
-      rbuf += fmt::format(i ? " {:02x}" : "{:02x}", (int)getRawErrBuff()[i]);
+      rbuf += fmt::format(fmt::runtime(i ? " {:02x}" : "{:02x}"), (int)getRawErrBuff()[i]);
     }
     rbuf += '>';
     return rbuf;
diff --git a/Detectors/ITSMFT/common/reconstruction/src/RUInfo.cxx b/Detectors/ITSMFT/common/reconstruction/src/RUInfo.cxx
@@ -35,5 +35,5 @@ std::string ChipInfo::asString() const
 
 void ChipInfo::print() const
 {
-  LOGP(info, asString());
+  LOGP(info, fmt::runtime(asString()));
 }
diff --git a/Detectors/MUON/MCH/Calibration/src/PedestalData.cxx b/Detectors/MUON/MCH/Calibration/src/PedestalData.cxx
@@ -120,7 +120,7 @@ void PedestalData::merge(const PedestalData* prev)
 void PedestalData::print() const
 {
   for (const auto& p : const_cast<PedestalData&>(*this)) {
-    LOGP(info, p.asString());
+    LOGP(info, fmt::runtime(p.asString()));
   }
 }
 
diff --git a/Detectors/MUON/MCH/DigitFiltering/src/DigitFilteringSpec.cxx b/Detectors/MUON/MCH/DigitFiltering/src/DigitFilteringSpec.cxx
@@ -88,7 +88,7 @@ class DigitFilteringTask
 
       if (!isOK(error)) {
         if (error.nofOutOfBounds > 0) {
-          LOGP(error, asString(error));
+          LOGP(error, "{}", asString(error));
           LOGP(error, "in a TF with {} rofs and {} digits", iRofs.size(), iDigits.size());
           abort = true;
         }
diff --git a/Detectors/MUON/MCH/Mapping/test/src/testPadIndices.cxx b/Detectors/MUON/MCH/Mapping/test/src/testPadIndices.cxx
@@ -102,7 +102,7 @@ int main(int argc, char** argv)
   int nbad{0};
 
   for (auto de : deIds) {
-    std::string filepath(fmt::format(filePattern, de));
+    std::string filepath(fmt::format(fmt::runtime(filePattern), de));
     std::ifstream in(filepath);
     if (!in) {
       std::cout << "Cannot open " << filepath << "\n";
diff --git a/Detectors/MUON/MCH/PreClustering/src/PreClusterFinderSpec.cxx b/Detectors/MUON/MCH/PreClustering/src/PreClusterFinderSpec.cxx
@@ -83,7 +83,7 @@ class PreClusterFinderTask
       LOG(info) << "deinitializing preclusterizer in: "
                 << std::chrono::duration<double, std::milli>(tEnd - tStart).count() << " ms";
       mErrorMap.forEach([](Error error) {
-        LOGP(warning, error.asString());
+        LOGP(warning, "{}", error.asString());
       });
     };
     ic.services().get<CallbackService>().set<CallbackService::Id::Stop>(stop);
@@ -117,7 +117,7 @@ class PreClusterFinderTask
       if (!isOK(error)) {
         if (error.nofOutOfBounds > 0) {
           // FIXME: replace this error log with a counters' message ?
-          LOGP(error, asString(error));
+          LOGP(error, "{}", asString(error));
           LOGP(error, "in a TF with {} rofs and {} digits", digitROFs.size(), digits.size());
           abort = true;
         }
diff --git a/Detectors/MUON/MCH/Raw/Decoder/src/testUserLogicEndpointDecoder.cxx b/Detectors/MUON/MCH/Raw/Decoder/src/testUserLogicEndpointDecoder.cxx
@@ -369,7 +369,7 @@ BOOST_AUTO_TEST_CASE_TEMPLATE(SyncInTheMiddleChargeSumModeTwoChannels, V, testTy
     5);
   std::string r2 = "S361-J6-DS2-ch-63-ts-345-q-123456-cs-789\n";
   r2 += "S361-J6-DS2-ch-63-ts-346-q-789012-cs-345\n";
-  r2 += fmt::format("S361-J6-DS2-chip-5-error-{}\n", ErrorUnexpectedSyncPacket);
+  r2 += fmt::format("S361-J6-DS2-chip-5-error-{}\n", (int)ErrorUnexpectedSyncPacket);
   BOOST_CHECK_EQUAL(r, r2);
 }
 
@@ -387,7 +387,7 @@ BOOST_AUTO_TEST_CASE_TEMPLATE(TestCruPageBadClusterSize, V, testTypes)
   gsl::span<const uint64_t> page = CruPageBadClusterSize;
   std::string r = testPayloadDecodeCruPages<V::value>(page);
   BOOST_CHECK_EQUAL(r,
-                    fmt::format("S81-J0-DS0-chip-1-error-{}\nS81-J0-DS0-ch-42-ts-0-q-1\n", ErrorBadClusterSize));
+                    fmt::format("S81-J0-DS0-chip-1-error-{}\nS81-J0-DS0-ch-42-ts-0-q-1\n", (int)ErrorBadClusterSize));
 }
 
 BOOST_AUTO_TEST_CASE_TEMPLATE(TestCruPageBadN10bitWords, V, testTypes)
@@ -396,7 +396,7 @@ BOOST_AUTO_TEST_CASE_TEMPLATE(TestCruPageBadN10bitWords, V, testTypes)
   std::string r = testPayloadDecodeCruPages<V::value>(page);
   std::string expected =
     fmt::format("S81-J0-DS0-ch-42-ts-87-q-2-1-0-0-1-0-0-0\nS81-J0-DS0-chip-1-error-{}\nS81-J0-DS0-ch-42-ts-0-q-1\n",
-                ErrorBadIncompleteWord);
+                (int)ErrorBadIncompleteWord);
   BOOST_CHECK_EQUAL(r, expected);
 }
 
diff --git a/Detectors/MUON/MCH/Raw/Encoder/Digit/DigitTreeReader.cxx b/Detectors/MUON/MCH/Raw/Encoder/Digit/DigitTreeReader.cxx
@@ -20,7 +20,7 @@ void AssertBranch(ROOT::Internal::TTreeReaderValueBase& value)
 {
   if (value.GetSetupStatus() < 0) {
     throw std::invalid_argument(fmt::format("Error {} setting up tree reader for branch {}",
-                                            value.GetSetupStatus(), value.GetBranchName()));
+                                            (int)value.GetSetupStatus(), value.GetBranchName()));
   }
 }
 
diff --git a/Detectors/MUON/MCH/Raw/test/testClosureCoDec.cxx b/Detectors/MUON/MCH/Raw/test/testClosureCoDec.cxx
@@ -104,7 +104,7 @@ std::vector<std::byte> paginate(gsl::span<const std::byte> buffer, const std::st
   return pages;
 }
 
-const char* sampaClusterFormat = "{}-CH{}-{}";
+constexpr const char* sampaClusterFormat = "{}-CH{}-{}";
 
 // Create a vector of SampaCluster from a string d
 // where d is of the form ts-#-bc-#-cs-#-q-# or
diff --git a/Detectors/MUON/MCH/Raw/test/testClosureCoDecDigit.cxx b/Detectors/MUON/MCH/Raw/test/testClosureCoDecDigit.cxx
@@ -28,7 +28,7 @@
 
 using namespace o2::mch::raw;
 
-const char* sampaClusterFormat = "{}-CH{}-{}";
+constexpr const char* sampaClusterFormat = "{}-CH{}-{}";
 const bool useDummyElecMap = true;
 
 struct DePadId {
diff --git a/Detectors/MUON/MCH/Tracking/src/TrackFinderSpec.cxx b/Detectors/MUON/MCH/Tracking/src/TrackFinderSpec.cxx
@@ -105,7 +105,7 @@ class TrackFinderTask
       mTrackFinder.printTimers();
       LOG(info) << "tracking duration = " << mElapsedTime.count() << " s";
       mErrorMap.forEach([](Error error) {
-        LOGP(warning, error.asString());
+        LOGP(warning, "{}", error.asString());
       });
     };
     ic.services().get<CallbackService>().set<CallbackService::Id::Stop>(stop);
diff --git a/Detectors/MUON/MCH/Workflow/src/ClusterFinderGEMSpec.cxx b/Detectors/MUON/MCH/Workflow/src/ClusterFinderGEMSpec.cxx
@@ -173,7 +173,7 @@ class ClusterFinderGEMTask
         mGEMDump = nullptr;
       }
       mErrorMap.forEach([](Error error) {
-        LOGP(warning, error.asString());
+        LOGP(warning, "{}", error.asString());
       });
     });
     auto stop = [this]() {
diff --git a/Detectors/MUON/MCH/Workflow/src/ClusterFinderOriginalSpec.cxx b/Detectors/MUON/MCH/Workflow/src/ClusterFinderOriginalSpec.cxx
@@ -73,7 +73,7 @@ class ClusterFinderOriginalTask
     ic.services().get<CallbackService>().set<CallbackService::Id::Stop>([this]() {
       LOG(info) << "cluster finder duration = " << mTimeClusterFinder.count() << " s";
       mErrorMap.forEach([](Error error) {
-        LOGP(warning, error.asString());
+        LOGP(warning, fmt::runtime(error.asString()));
       });
       this->mClusterFinder.deinit();
     });
diff --git a/Detectors/Raw/TFReaderDD/src/tf-reader-workflow.cxx b/Detectors/Raw/TFReaderDD/src/tf-reader-workflow.cxx
@@ -86,7 +86,7 @@ WorkflowSpec defineDataProcessing(ConfigContext const& configcontext)
   int rateLimitingIPCID = std::stoi(configcontext.options().get<std::string>("timeframes-rate-limit-ipcid"));
   std::string chanFmt = configcontext.options().get<std::string>("metric-feedback-channel-format");
   if (rateLimitingIPCID > -1 && !chanFmt.empty()) {
-    rinp.metricChannel = fmt::format(chanFmt, o2::framework::ChannelSpecHelpers::defaultIPCFolder(), rateLimitingIPCID);
+    rinp.metricChannel = fmt::format(fmt::runtime(chanFmt), o2::framework::ChannelSpecHelpers::defaultIPCFolder(), rateLimitingIPCID);
   }
 
   WorkflowSpec specs;
diff --git a/Detectors/Raw/src/RawDumpSpec.cxx b/Detectors/Raw/src/RawDumpSpec.cxx
@@ -273,7 +273,7 @@ void RawDump::endOfStream(EndOfStreamContext& ec)
     auto fnm = fmt::format("{}{}{}raw.cfg", mOutDir, mOutDir.back() == '/' ? "" : "/", DetID::getName(id));
     auto fh = std::fopen(fnm.c_str(), "w");
     if (!fh) {
-      LOGP(fatal, "Failed to create configuration file {}");
+      LOGP(fatal, "Failed to create configuration file {}", fnm);
     }
     auto ws = std::fwrite(mConfigEntries[id].data(), 1, mConfigEntries[id].size(), fh);
     if (ws != mConfigEntries[id].size()) {
@@ -655,7 +655,7 @@ std::string RawDump::getBaseFileNameTRD(const header::RDHAny* rdh)
   int link = supermodule * 4 + side * 2 + ep, cru = link / 2;
   if (link >= NLinks) {
     auto flpname = fmt::format("flp-unknown_cru{}_ep{}_feeid0x{:05x}", cru, int(RDHUtils::getEndPointID(rdh)), RDHUtils::getFEEID(rdh));
-    LOGP(error, "Got wrong link {}, setting TRF file name to unrecognized flp {}", flpname);
+    LOGP(error, "Got wrong link {}, setting TRF file name to unrecognized flp {}", link, flpname);
     return flpname;
   }
   return fmt::format("alio2-cr1-flp{}_cru{}_{}", trdHWMap[cru].flpid, trdHWMap[cru].cruHWID, ep);
diff --git a/Detectors/Raw/src/rawfile-reader-workflow.cxx b/Detectors/Raw/src/rawfile-reader-workflow.cxx
@@ -90,7 +90,7 @@ WorkflowSpec defineDataProcessing(ConfigContext const& configcontext)
   int rateLimitingIPCID = std::stoi(configcontext.options().get<std::string>("timeframes-rate-limit-ipcid"));
   std::string chanFmt = configcontext.options().get<std::string>("metric-feedback-channel-format");
   if (rateLimitingIPCID > -1 && !chanFmt.empty()) {
-    rinp.metricChannel = fmt::format(chanFmt, o2::framework::ChannelSpecHelpers::defaultIPCFolder(), rateLimitingIPCID);
+    rinp.metricChannel = fmt::format(fmt::runtime(chanFmt), o2::framework::ChannelSpecHelpers::defaultIPCFolder(), rateLimitingIPCID);
   }
   o2::conf::ConfigurableParam::updateFromString(configcontext.options().get<std::string>("configKeyValues"));
   auto hbfini = configcontext.options().get<std::string>("hbfutils-config");
diff --git a/Detectors/TPC/base/include/TPCBase/CalDet.h b/Detectors/TPC/base/include/TPCBase/CalDet.h
@@ -463,7 +463,7 @@ void CalDet<T>::initData()
     if (!hasData) {
       mData.push_back(CalType(mPadSubset, i));
     }
-    mData[i].setName(fmt::format(frmt, mName, i));
+    mData[i].setName(fmt::format(fmt::runtime(frmt), mName, i));
   }
 }
 
diff --git a/Detectors/TPC/base/src/CDBInterface.cxx b/Detectors/TPC/base/src/CDBInterface.cxx
@@ -633,5 +633,5 @@ void CDBStorage::printObjectSummary(std::string_view name, CDBType const type, M
     message += fmt::format("{:>20} = {}\n", key, value);
   }
 
-  LOGP(info, message);
+  LOGP(info, "{}", message);
 }
diff --git a/Detectors/TPC/base/src/FEEConfig.cxx b/Detectors/TPC/base/src/FEEConfig.cxx
@@ -133,7 +133,7 @@ void FEEConfig::print() const
   fmt::print("{0:=^{1}}\n", message, boxWidth);
 
   if (cruConfig.size() != CRU::MaxCRU) {
-    LOGP(error, "Unexpected size of cru config:{} != {}", cruConfig.size(), CRU::MaxCRU);
+    LOGP(error, "Unexpected size of cru config:{} != {}", cruConfig.size(), (int)CRU::MaxCRU);
   } else {
     for (int iCRU = 0; iCRU < cruConfig.size(); ++iCRU) {
       const auto& c = cruConfig.at(iCRU);
diff --git a/Detectors/TPC/calibration/src/CalibTreeDump.cxx b/Detectors/TPC/calibration/src/CalibTreeDump.cxx
@@ -223,7 +223,7 @@ void CalibTreeDump::addCalDetObjects(TTree* tree)
     std::string name = calDet.getName();
 
     if (name == "PadCalibrationObject" || name.size() == 0) {
-      name = fmt::format("calDet_{%02d}", iter);
+      name = fmt::format(fmt::runtime("calDet_{%02d}"), iter);
     }
 
     std::string meanName = fmt::format("{}_mean", name);
diff --git a/Detectors/TPC/calibration/src/CalibdEdx.cxx b/Detectors/TPC/calibration/src/CalibdEdx.cxx
@@ -215,7 +215,8 @@ void fitHist(const Hist& hist, CalibdEdxCorrection& corr, TLinearFitter& fitter,
         corr.setChi2(id, charge, fitter.GetChisquare());
         corr.setEntries(id, charge, entries);
       }
-      LOGP(debug, "Sector: {}, gemType: {}, charge: {}, Fit pass: {} with {} % outliers in {} entries. Fitter Points: {}, mean fit: {}", id.sector, int(id.type), charge, fitPass, (float)outliers / (float)entries * 100, entries, fitter.GetNpoints(), params[0]);
+      LOGP(debug, "Sector: {}, gemType: {}, charge: {}, Fit pass: {} with {} % outliers in {} entries. Fitter Points: {}, mean fit: {}",
+           id.sector, int(id.type), int(charge), fitPass, (float)outliers / (float)entries * 100, entries, fitter.GetNpoints(), params[0]);
     }
   }
 }
diff --git a/Detectors/TPC/calibration/src/VDriftHelper.cxx b/Detectors/TPC/calibration/src/VDriftHelper.cxx
@@ -43,7 +43,8 @@ VDriftHelper::VDriftHelper()
   if (o2::conf::ConfigurableParam::getProvenance("TPCDetParam.DriftTimeOffset") == o2::conf::ConfigurableParam::EParamProvenance::kRT) { // we stick to this value
     mVD.creationTime = std::numeric_limits<long>::max();
     mForceParamOffset = true;
-    LOGP(info, "TPC dridt time offset was set from command line to {} mus ({} TB}, will neglect update from CCDB", mVD.refTimeOffset, detpar.DriftTimeOffset);
+    LOGP(info, "TPC dridt time offset was set from command line to {} mus ({} TB), will neglect update from CCDB",
+         mVD.refTimeOffset, detpar.DriftTimeOffset);
   }
 
   mUpdated = true;
diff --git a/Detectors/TPC/dcs/src/DCSConfigSpec.cxx b/Detectors/TPC/dcs/src/DCSConfigSpec.cxx
@@ -289,7 +289,7 @@ void DCSConfigDevice::fillCRUConfig(gsl::span<const char> configBuff, bool updat
   }
 
   if (!update && (nLines != CRU::MaxCRU)) {
-    LOGP(error, "Full FEEConfig expected, but only {} / {} lines read for CRUConfig", nLines, CRU::MaxCRU);
+    LOGP(error, "Full FEEConfig expected, but only {} / {} lines read for CRUConfig", nLines, (int)CRU::MaxCRU);
   } else {
     LOGP(info, "updating CRUConfig for {} crus", nLines);
   }
diff --git a/Detectors/TPC/dcs/src/DCSProcessor.cxx b/Detectors/TPC/dcs/src/DCSProcessor.cxx
@@ -69,7 +69,7 @@ float DCSProcessor::getValueF(const DPCOM& dp) const
   } else if (dp.id.get_type() == DeliveryType::DPVAL_DOUBLE) {
     return static_cast<float>(o2::dcs::getValue<double>(dp));
   } else {
-    LOGP(warning, "Unexpected delivery type for {}: {}", dp.id.get_alias(), dp.id.get_type());
+    LOGP(warning, "Unexpected delivery type for {}: {}", dp.id.get_alias(), (int)dp.id.get_type());
   }
 
   return 0.f;
@@ -94,7 +94,7 @@ void DCSProcessor::fillHV(const DPCOM& dp)
     // TODO: Remove once type is clear
     static bool statTypePrinted = false;
     if (!statTypePrinted) {
-      LOGP(info, "Delivery type for STATUS ({}): {}", alias, type);
+      LOGP(info, "Delivery type for STATUS ({}): {}", alias, (int)type);
       statTypePrinted = true;
     }
     if (type == DeliveryType::DPVAL_UINT) {
@@ -109,7 +109,7 @@ void DCSProcessor::fillHV(const DPCOM& dp)
     // TODO: Remove once type is clear
     static bool uiTypePrinted = false;
     if (!uiTypePrinted) {
-      LOGP(info, "Delivery type for current, voltage ({}): {}", alias, type);
+      LOGP(info, "Delivery type for current, voltage ({}): {}", alias, (int)type);
       uiTypePrinted = true;
     }
     const auto value = getValueF(dp);
diff --git a/Detectors/TPC/reconstruction/src/RawReaderCRU.cxx b/Detectors/TPC/reconstruction/src/RawReaderCRU.cxx
@@ -973,7 +973,7 @@ void RawReaderCRU::writeGBTDataPerLink(std::string_view outputDirectory, int max
 
       const int ep = iLink >= 12;
       const int link = iLink - (ep)*12;
-      auto outputFileName = fmt::format("{}/CRU_{:02}_EP_{}_Link_{:02}", outputDirectory.data(), mCRU, ep, link);
+      auto outputFileName = fmt::format("{}/CRU_{:02}_EP_{}_Link_{:02}", outputDirectory.data(), (int)mCRU, ep, link);
       std::ofstream outputFile(outputFileName, std::ios_base::binary | std::ios_base::app);
 
       for (auto packetNumber : linkInfo.PacketPositions) {
diff --git a/Detectors/TPC/workflow/include/TPCWorkflow/TPCFactorizeIDCSpec.h b/Detectors/TPC/workflow/include/TPCWorkflow/TPCFactorizeIDCSpec.h
@@ -311,7 +311,7 @@ class TPCFactorizeIDCSpec : public o2::framework::Task
             o2::ccdb::CcdbObjectInfo ccdbInfoIDCDelta(CDBTypeMap.at(sideA ? CDBType::CalIDCDeltaA : CDBType::CalIDCDeltaC), std::string{}, std::string{}, std::map<std::string, std::string>{}, timeStampStartDelta, timeStampEndDelta);
 
             if (mDumpIDCDelta) {
-              mIDCGrouping.dumpToFile(fmt::format("{}DeltaAveraged_chunk{:02}_{:02}_side{}.root", getCurrentType(), iChunk, timeStampStartDelta, side).data());
+              mIDCGrouping.dumpToFile(fmt::format("{}DeltaAveraged_chunk{:02}_{:02}_side{}.root", getCurrentType(), iChunk, timeStampStartDelta, (int)side).data());
             }
 
             auto startCCDBIDCDelta = timer::now();
diff --git a/Detectors/TPC/workflow/include/TPCWorkflow/TPCFourierTransformAggregatorSpec.h b/Detectors/TPC/workflow/include/TPCWorkflow/TPCFourierTransformAggregatorSpec.h
@@ -125,7 +125,7 @@ class TPCFourierTransformAggregatorSpec : public o2::framework::Task
 
           if (mDumpFFT) {
             LOGP(info, "dumping FT to file");
-            mIDCFourierTransform[side].dumpToFile(fmt::format("FourierAGG_{:02}_side{}.root", processing_helpers::getCurrentTF(pc), side).data());
+            mIDCFourierTransform[side].dumpToFile(fmt::format("FourierAGG_{:02}_side{}.root", processing_helpers::getCurrentTF(pc), (int)side).data());
           }
 
           if (mSendOutDebug) {
diff --git a/Detectors/TPC/workflow/src/ClusterQCSpec.cxx b/Detectors/TPC/workflow/src/ClusterQCSpec.cxx
diff --git a/Detectors/TPC/workflow/src/IDCToVectorSpec.cxx b/Detectors/TPC/workflow/src/IDCToVectorSpec.cxx
diff --git a/Detectors/TRD/qc/src/Tracking.cxx b/Detectors/TRD/qc/src/Tracking.cxx

Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,7 @@ bool publish(std::string const& filename, std::string const& path, std::string C`
`205`	`205`	`try {`
`206`	`206`	`o2::utils::createDirectoriesIfAbsent(targetdir);`
`207`	`207`	`} catch (std::exception e) {`
`208`		`- LOGP(error, fmt::format("Could not create local snapshot cache directory {}, reason: {}", targetdir, e.what()));`
	`208`	`+ LOGP(error, "Could not create local snapshot cache directory {}, reason: {}", targetdir, e.what());`
`209`	`209`	`return false;`
`210`	`210`	`}`
`211`	`211`
Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ WorkflowSpec defineDataProcessing(ConfigContext const& configcontext)`
`134`	`134`	`int rateLimitingIPCID = std::stoi(configcontext.options().get<std::string>("timeframes-rate-limit-ipcid"));`
`135`	`135`	`std::string chanFmt = configcontext.options().get<std::string>("metric-feedback-channel-format");`
`136`	`136`	`if (rateLimitingIPCID > -1 && !chanFmt.empty()) {`
`137`		`- ctfInput.metricChannel = fmt::format(chanFmt, o2::framework::ChannelSpecHelpers::defaultIPCFolder(), rateLimitingIPCID);`
	`137`	`+ ctfInput.metricChannel = fmt::format(fmt::runtime(chanFmt), o2::framework::ChannelSpecHelpers::defaultIPCFolder(), rateLimitingIPCID);`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`specs.push_back(o2::ctf::getCTFReaderSpec(ctfInput));`
Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ std::vector<std::string> extractRange(std::string range)`
`82`	`82`	`std::vector<std::string> result;`
`83`	`83`
`84`	`84`	`for (auto i = a; i <= b; i++) {`
`85`		`- auto substituted = fmt::format(intFormat, i);`
	`85`	`+ auto substituted = fmt::format(fmt::runtime(intFormat), i);`
`86`	`86`	`result.push_back(substituted);`
`87`	`87`	`}`
`88`	`88`	`return result;`
`@@ -124,7 +124,7 @@ std::vector<std::string> expandAlias(const std::string& pattern)`
`124`	`124`	`std::vector<std::string> result;`
`125`	`125`
`126`	`126`	`for (auto r : range) {`
`127`		`- auto substituted = fmt::format(newPattern, r);`
	`127`	`+ auto substituted = fmt::format(fmt::runtime(newPattern), r);`
`128`	`128`	`result.emplace_back(substituted);`
`129`	`129`	`}`
`130`	`130`
Original file line number	Diff line number	Diff line change
`@@ -395,7 +395,7 @@ double HMPIDDCSProcessor::calculatePhotonEnergy(int i)`
`395`	`395`	`if (dp.id.get_type() == DeliveryType::DPVAL_DOUBLE) {`
`396`	`396`	`lambda = o2::dcs::getValue<double>(dp);`
`397`	`397`	`} else {`
`398`		`- LOGP(warn, "DP type is {}", dp.id.get_type());`
	`398`	`+ LOGP(warn, "DP type is {}", (int)dp.id.get_type());`
`399`	`399`	`LOGP(warn, "Not correct datatype for HMP_TRANPLANT_MEASURE_{}_WAVELENGTH --> Default wavelength used for iteration procTrans{}", i, i);`
`400`	`400`	`lambda = arrWaveLenDefault[i];`
`401`	`401`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1384,7 +1384,7 @@ int MillePede2::SolveGlobalMatEq()`
`1384`	`1384`	`if (fgIterSol == MinResSolve::kSolFGMRes) {`
`1385`	`1385`	`res = slv->SolveFGMRES(sol, fgMinResCondType, fgMinResMaxIter, fgMinResTol, fgNKrylovV);`
`1386`	`1386`	`} else {`
`1387`		`- LOGF(warning, "MillePede2 - Undefined Iteritive Solver ID=%d, only %d are defined", fgIterSol, MinResSolve::kNSolvers);`
	`1387`	`+ LOGF(warning, "MillePede2 - Undefined Iteritive Solver ID=%d, only %d are defined", fgIterSol, (int)MinResSolve::kNSolvers);`
`1388`	`1388`	`}`
`1389`	`1389`	`}`
`1390`	`1390`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ std::string ChipPixelData::getErrorDetails(int pos) const`
`48`	`48`	`std::string rbuf = ": 0x<";`
`49`	`49`	`int nc = getNBytesInRawBuff();`
`50`	`50`	`for (int i = 0; i < nc; i++) {`
`51`		`- rbuf += fmt::format(i ? " {:02x}" : "{:02x}", (int)getRawErrBuff()[i]);`
	`51`	`+ rbuf += fmt::format(fmt::runtime(i ? " {:02x}" : "{:02x}"), (int)getRawErrBuff()[i]);`
`52`	`52`	`}`
`53`	`53`	`rbuf += '>';`
`54`	`54`	`return rbuf;`
Original file line number	Diff line number	Diff line change
`@@ -35,5 +35,5 @@ std::string ChipInfo::asString() const`
`35`	`35`
`36`	`36`	`void ChipInfo::print() const`
`37`	`37`	`{`
`38`		`- LOGP(info, asString());`
	`38`	`+ LOGP(info, fmt::runtime(asString()));`
`39`	`39`	`}`