Framework: make sure we support fmt 10.1.1

Author: ktf

CCDB/src/CcdbApi.cxx

@@ -710,7 +710,7 @@ bool CcdbApi::retrieveBlob(std::string const& path, std::string const& targetdir
   try {
     o2::utils::createDirectoriesIfAbsent(fulltargetdir);
   } catch (std::exception e) {
-    LOGP(error, fmt::format("Could not create local snapshot cache directory {}, reason: {}", fulltargetdir, e.what()));
+    LOGP(error, "Could not create local snapshot cache directory {}, reason: {}", fulltargetdir, e.what());
     return false;
   }
 

Common/Field/src/MagneticField.cxx

@@ -539,7 +539,7 @@ void MagneticField::rescaleField(float l3Cur, float diCur, bool uniform, int con
   float sclL3 = l3Cur, sclDip = diCur;
   MagFieldParam::BMap_t map = getFieldMapScale(sclL3, sclDip, uniform);
   if (map != mMapType) {
-    LOGP(fatal, "Provided L3current={} DipCurrent={} uniform={} leads to map type {}, incompatible with loaded {}", l3Cur, diCur, uniform, map, mMapType);
+    LOGP(fatal, "Provided L3current={} DipCurrent={} uniform={} leads to map type {}, incompatible with loaded {}", l3Cur, diCur, uniform, (int)map, (int)mMapType);
   }
   setFactorSolenoid(sclL3);
   setFactorDipole(sclDip);

Detectors/AOD/src/AODProducerWorkflowSpec.cxx

@@ -1221,7 +1221,7 @@ void AODProducerWorkflowDPL::fillSecondaryVertices(const o2::globaltracking::Rec
       if (item != mGIDToTableID.end()) {
         tableIdx[i] = item->second;
       } else {
-        LOG(warn) << fmt::format("Could not find a track index for prong ID {}", trIDs[i]);
+        LOG(warn) << fmt::format("Could not find a track index for prong ID {}", (int)trIDs[i]);
         missing = true;
       }
     }

EventVisualisation/Workflow/src/FileProducer.cxx

@@ -47,7 +47,7 @@ std::string FileProducer::newFileName() const
   gethostname(hostname, _POSIX_HOST_NAME_MAX);
 
   auto pid = getpid();
-  auto result = fmt::format(this->mName,
+  auto result = fmt::format(fmt::runtime(this->mName),
                             fmt::arg("hostname", hostname),
                             fmt::arg("pid", pid),
                             fmt::arg("timestamp", millisec_since_epoch),

Framework/AnalysisSupport/src/AODJAlienReaderHelpers.cxx

@@ -246,11 +246,11 @@ AlgorithmSpec AODJAlienReaderHelpers::rootFileReaderCallback()
             // get first folder of next file
             ntf = 0;
             if (!didir->readTree(outputs, dh, fcnt, ntf, totalSizeCompressed, totalSizeUncompressed)) {
-              LOGP(fatal, "Can not retrieve tree for table {}: fileCounter {}, timeFrame {}", concrete.origin, fcnt, ntf);
+              LOGP(fatal, "Can not retrieve tree for table {}: fileCounter {}, timeFrame {}", concrete.origin.as<std::string>(), fcnt, ntf);
               throw std::runtime_error("Processing is stopped!");
             }
           } else {
-            LOGP(fatal, "Can not retrieve tree for table {}: fileCounter {}, timeFrame {}", concrete.origin, fcnt, ntf);
+            LOGP(fatal, "Can not retrieve tree for table {}: fileCounter {}, timeFrame {}", concrete.origin.as<std::string>(), fcnt, ntf);
             throw std::runtime_error("Processing is stopped!");
           }
         }

Framework/Core/src/DPLWebSocket.cxx

@@ -375,7 +375,7 @@ void WSDPLHandler::write(std::vector<uv_buf_t>& outputs)
 /// Helper to return an error
 void WSDPLHandler::error(int code, char const* message)
 {
-  static char const* errorFMT = "HTTP/1.1 {} {}\r\ncontent-type: text/plain\r\n\r\n{}: {}\r\n";
+  static constexpr auto errorFMT = "HTTP/1.1 {} {}\r\ncontent-type: text/plain\r\n\r\n{}: {}\r\n";
   std::string error = fmt::format(errorFMT, code, message, code, message);
   char* reply = strdup(error.data());
   uv_buf_t bfr = uv_buf_init(reply, error.size());

Framework/Core/src/DataOutputDirector.cxx

@@ -584,7 +584,7 @@ void DataOutputDirector::printOut()
 
   LOGP(info, "  File name bases      :");
   for (auto const& fb : mfilenameBases) {
-    LOGP(info, fb);
+    LOGP(info, "{}", fb);
   }
 }
 

Framework/Core/src/DataProcessingContext.cxx

@@ -52,7 +52,7 @@ void DataProcessorContext::preDanglingCallbacks(DanglingContext& danglingContext
 void DataProcessorContext::postDanglingCallbacks(DanglingContext& danglingContext)
 {
   for (auto& handle : postDanglingHandles) {
-    LOGP(debug, "Invoking postDanglingCallback for service {} {}", handle.spec.name);
+    LOGP(debug, "Invoking postDanglingCallback for service {}", handle.spec.name);
     handle.callback(danglingContext, handle.service);
   }
 }

Framework/Core/src/HTTPParser.cxx

@@ -189,7 +189,7 @@ void decode_websocket(char* start, size_t size, WebSocketHandler& handler)
 std::string encode_websocket_handshake_request(const char* endpoint, const char* protocol, int version, char const* nonce,
                                                std::vector<std::pair<std::string, std::string>> headers)
 {
-  char const* res =
+  constexpr auto res =
     "GET {} HTTP/1.1\r\n"
     "Upgrade: websocket\r\n"
     "Connection: Upgrade\r\n"
@@ -216,7 +216,7 @@ std::string HTTPParserHelpers::calculateAccept(const char* nonce)
 
 std::string encode_websocket_handshake_reply(char const* nonce)
 {
-  char const* res =
+  constexpr auto res =
     "HTTP/1.1 101 Switching Protocols\r\n"
     "Upgrade: websocket\r\n"
     "Connection: Upgrade\r\n"

Framework/Core/src/runDataProcessing.cxx

@@ -696,7 +696,7 @@ void spawnDevice(uv_loop_t* loop,
   close(childFds[ref.index].childstdout[1]);
   if (varmap.count("post-fork-command")) {
     auto templateCmd = varmap["post-fork-command"];
-    auto cmd = fmt::format(templateCmd.as<std::string>(),
+    auto cmd = fmt::format(fmt::runtime(templateCmd.as<std::string>()),
                            fmt::arg("pid", id),
                            fmt::arg("id", spec.id),
                            fmt::arg("cpu", parentCPU),